@jlcesarr
Submitted
Feel free to leave a feedback. Thanks for your attention!
@Sam-Guliker
@jlcesarr
Submitted
Feel free to leave a feedback. Thanks for your attention!
@Sam-Guliker
Posted
Hi, jlcesarr
Try to use landmarks like so: <main> {your content}</main>
instead of section.
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles#abstract_roles
Happy coding
Marked as helpful
@DrunkenNeoguri
Submitted
Good to See You!
Previously, I challenged this project a week ago. This solution is a rechallenge and review for previous challenge project.
I hope to give me feedback. I will study hard by referring to it, thank you! :D
@Sam-Guliker
Posted
Hi Drunken,
Looks good! I would recommand you to check out the fonts. They seem a bit off.
Goodluck
Marked as helpful
@DanyGlez94
Submitted
Hi everyone! Thanks in advance for checking out my code! Any suggestions are welcomed! 😜
If you want to know how to find out if the user prefers dark or light mode based on their device preferences, check out my code, it took me a while to find out how to do it, but it was easier than I thought.
const darkOrLight = () => {
const dark = window.matchMedia && window.matchMedia('(prefers-color-scheme: dark)').matches;
if (dark === true) {
console.log('User prefers dark mode');
} else {
console.log('User prefers light mode');
document.body.classList.add('light');
}
}
Happy coding! 😉✌
@Sam-Guliker
Posted
Hi Daniel,
Looks good! To remove the HTML issues:
Happy coding
Marked as helpful
Hello Community, I would like if you give me suggestion regarding code improvement, mistakes I did in code, improvement, etc. I am also facing difficulty in responsive designing in this tasks, if you suggest the improvements and other things that I should work on. It would be really helpful, if you suggest improvements or mistakes.
@Sam-Guliker
Posted
Hi, Abhisek
Double check the paddings and fonts? They seem a bit off.
Next to that try to use landmarks like so: <main> {your content}</main>
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/main_role
A heading is also nice to have :) https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Heading_Elements
Happy coding
@JoShobande
Submitted
Please i will need feedback on the responsiveness of the page. i will also need feedback on my code in general: is my code clean enough? did i employ on the the best solutions?
@Sam-Guliker
Posted
Hi Josephine,
You can find a lot of feedback in the report. There are some issues when it comes to images and structure of the headings.
And the design seems a bit off on desktop. Take a good look at paddings, font-size and buttons.
Happy coding
@GitHub-dev12345
Submitted
This WebPage Profile-Card, built by Html5 & CSS, In this Project Css Code Reable and understandable to others developers, In this Project this card Responsive Code Very easy and understood.
#100DaysOfCode #WebDevelopment #100DaysDev
@Sam-Guliker
Posted
Hey Rathore,
Good stuff, keep it up!
@Captressketh001
Submitted
I will love to have a feedback on how I can make the toggle better
@Sam-Guliker
Posted
Hi Captress,
You're almost there. You can still improve the HTML by using aria labels on the <a> tag. Next to that check the headings, H5 doesn't seem neccisary.
Design wise, check the fonts, paddings and buttons.
Have a good day
@stfnpczk
Submitted
As always, any and all feedback is greatly appreciated! 😀
@Sam-Guliker
Posted
Hi Stefan,
Looks good! I'm not sure if the rendering isn't good but it seems like the fonts in the design are a bit lighter(like thin or regular). The request button needs a bit more padding on the right side.
Have a good day
Marked as helpful
@NerijusNoreika
Submitted
Made with Vue along with Grid and Flexbox and SCSS.
Most annoying part was the range styling.
Feedback is always appreciated! ;)
@Sam-Guliker
Posted
Hi, Nerijus
Looks good but there are a couple of things design-wise that needs some attention.
Happy coding
@Enrym
Submitted
Nice training for flexbox and img overlays. Feel like my HTML structure and classes are messy, are they?
@Sam-Guliker
Posted
Hi Enrym
Good solution you've got there. Try to use landmarks like so: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/landmark_role
Normally you don't use section's like that. For styling always use a div :)
Have a good day,
Would love if I can receive strong professional, advice in relation to how i can do better
@Sam-Guliker
Posted
Hi Eblite,
Nice solution you've got there, there are a couple of things you can pay attention to. HTML:
CSS:
I hope this was helpfull
Happy coding
@walker861
Submitted
This was my first attempt with use of a media query. Any feedback on @media rule would be greatly appreciated. Any other constructive criticism is welcome as well. Thanks all!
@Sam-Guliker
Posted
Hi Walker,
Nice solution you've got there. The main doesn't really need a role since the html is already telling that it's a main.
For the design you are really close. Try to play a bit with paddings and you can do a "50/50" width solution.
Happy coding.
Marked as helpful