Frontend Mentor | Sam Guliker's profile

@jlcesarrSubmitted about 3 years ago

Responsive order summary component with grid and flex containers

@Sam-GulikerPosted about 3 years ago

Hi, jlcesarr

Try to use landmarks like so: <main> {your content}</main> instead of section. https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles#abstract_roles

Happy coding

Marked as helpful

1

drunken_neoguri•290

@DrunkenNeoguriSubmitted about 3 years ago

Rechallenge/Review: NFT preview card

1

Sam Guliker•540

@Sam-GulikerPosted about 3 years ago

Hi Drunken,

Looks good! I would recommand you to check out the fonts. They seem a bit off.

Goodluck

Marked as helpful

1

Daniel González•40

@DanyGlez94Submitted about 3 years ago

GitHub User Search App — Mobile-1st, SASS, BEM, API & JS.

#accessibility#bem#sass/scss#fetch

2

Sam Guliker•540

@Sam-GulikerPosted about 3 years ago

Hi Daniel,

Looks good! To remove the HTML issues:

Use an alt tag on your <img> tag
If you use sections use a heading, else try to use a div

Happy coding

Marked as helpful

0

Abhishek Waghmare•30

@abhishekdwaghmare2000Submitted about 3 years ago

Order Summary Componet webpage

#backbone#foundation#materialize-css#accessibility

6

Sam Guliker•540

@Sam-GulikerPosted about 3 years ago

Hi, Abhisek

Double check the paddings and fonts? They seem a bit off. Next to that try to use landmarks like so: <main> {your content}</main> https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/main_role

A heading is also nice to have :) https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Heading_Elements

Happy coding

1