RabicaTahir
@RabicaTahirAll comments
- @DiogopegorelSubmitted over 1 year ago@RabicaTahirPosted over 1 year ago
salam o Alaikum! @Diogopegorel. π―Congratulations on completing the challenge !
π¬I have some suggestions about your code.
HTML π:
βͺ It is advisable that you place all your main site content in a landmark element <main>. Wrap the body code in main tag. Click & Wrap the code
<div class="container">
βͺ Best practice is to ensure that the beginning of a page's main content starts with a h1 element. Replace this
<p class="p1">Improve your front-end <br>skills by building projects</p>
βͺ Instead of using the <br> tag , you should use a semantic HTML element and the
CSS margin or padding properties.
CSS: π¨
πβͺ Check the style guide & change the background color.
πβͺ Instead of using pixels in font-size, using relative units like
em or rem
is a good practice.I hope you find it useful! By the way, the solution was great. ππ―
Enjoy coding, Stay Safe! π€
Marked as helpful1 - @kirubavathi-VMSubmitted over 1 year ago@RabicaTahirPosted over 1 year ago
Asalam o Alaikum! @kirubavathi-VM. π―Congratulations on completing the challenge !
π¬I have some suggestions about your code.
HTML π:
βͺ It is advisable that you place all your main site content in a landmark element <main>. Wrap the body code in main tag. Click & Wrap the code
<div class="container">
βͺ Best practice is to ensure that the beginning of a page's main content starts with a h1 element. Replace this
<h5>Improve your font-end <br>skills by building projects</h5>
βͺ Instead of using the <br> tag , you should use a semantic HTML element and the CSS margin or padding properties.
CSS: π¨
πβͺ Instead of using pixels in font-size, using relative units like em or rem is a good practice.
πβͺ Check the style guide & change the background color.
I hope you find it useful! By the way, the solution was great. ππ―
Enjoy coding, Stay Safe! π€
Marked as helpful0 - @lucaspmarraSubmitted over 1 year ago
font-weight: 400 changed nothing, something to worry about?
@RabicaTahirPosted over 1 year agoAsalam o Alaikum! @lucaspmarra. π―Congratulations on completing the challenge !
π¬I have some suggestions about your code.
HTML π:
βͺ It's necessary for images to have short, descriptive alt text so
screen reader
users clearly understand the image's contents and purpose.<img class="card-image" src="./images/image-qr-code.png" alt="">
CSS: π¨
πβͺ Instead of using pixels in font-size, using relative units like em or rem is a good practice.
I hope you find it useful! By the way, the solution was great. ππ―
Enjoy coding, Stay Safe! π€
1 - @atiqurrehman123Submitted over 1 year ago@RabicaTahirPosted over 1 year ago
Asalam o Alaikum! @atiqurrehman123. π―Congratulations on completing the challenge !
π¬I have some suggestions about your code.
HTML π:
βͺ It is advisable that you place all your main site content in a landmark element <main>. Wrap the body code in main tag. Click & Wrap the code
<div class="container">
βͺ Best practice is to ensure that the beginning of a page's main content starts with a h1 element. Replace this
<h5 class="card-heading">Improve your front-end <br />skills by building projects </h5>
βͺ Instead of using the <br> tag , you should use a
semantic HTML element
and the CSS margin or padding properties.CSS: π¨
πβͺ Instead of using pixels in font-size, using
relative units
like em or rem is a good practice.I hope you find it useful! By the way, the solution was great. ππ―
Enjoy coding, Stay Safe! π€
0 - @Rishabh2324Submitted over 1 year ago@RabicaTahirPosted over 1 year ago
Asalam o Alaikum! @Rishabh2324. π―Congratulations on completing the challenge !
π¬I have some suggestions about your code.
HTML π:
βͺ Best practice is to ensure that the beginning of a page's main content starts with a h1 element.
<h6 class="qr-details-title"> Improve your front-end skills by building projects </h6>
CSS: π¨
πβͺ Instead of using pixels in font-size, using
relative units
like em or rem is a good practice.I hope you find it useful! By the way, the solution was great. ππ―
Enjoy coding, Stay Safe! π€
0 - @Abdelrahman-Muhammed13Submitted over 1 year ago@RabicaTahirPosted over 1 year ago
Asalam o Alaikum! @Abdelrahman-Muhammed13. π―Congratulations on completing the challenge !
π¬I have some suggestions about your code.
HTML π:
βͺ It is advisable that you place all your main site content in a landmark element <main>. Wrap the body code in main tag. Click & Wrap the code
<div class="main-container">
βͺ It's necessary for images to have short, descriptive alt text so screen reader users clearly understand the image's contents and purpose.
<img src="../image-qr-code.png" >
CSS: π¨
πβͺ Instead of using pixels in font-size, using relative units like em or rem is a good practice.
I hope you find it useful! By the way, the solution was great. ππ―
Enjoy coding, Stay Safe! π€
Marked as helpful0 - @gustavo-atanazioSubmitted over 1 year ago@RabicaTahirPosted over 1 year ago
Asalam o Alaikum! @gustavo-atanazio. π―Congratulations on completing the challenge !
π¬I have some suggestions about your code.
HTML π:
βͺ It is advisable that you place all your main site content in a landmark element <main>. Wrap the body code in main tag.
<div class="container">
βͺ Best practice is to ensure that the beginning of a page's main content starts with a h1 element.
<span class="title">Improve your front-end skills by building projects</span>
CSS: π¨
πβͺ Instead of using pixels in font-size, using
relative units
like em or rem is a good practice.I hope you find it useful! By the way, the solution was great. ππ―
Enjoy coding, Stay Safe! π€
Marked as helpful0 - @terza85Submitted over 1 year ago@RabicaTahirPosted over 1 year ago
Asalam o Alaikum! @terza85. π―Congratulations on completing the challenge !
π¬I have some suggestions about your code.
HTML π:
βͺ It is advisable that you place all your main site content in a landmark element <main>. Wrap the body code in main tag. Click & Wrap the code
<div class="main-container">
βͺ Best practice is to ensure that the beginning of a page's main content starts with a h1 element. Replace this
<p class="heading">Improve your front-end skills by building projects</p>
βͺ It's necessary for images to have short, descriptive alt text so screen reader users clearly understand the image's contents and purpose.
<img src="images\image-qr-code.png" alt="" class="src">
CSS: π¨
πβͺ Instead of using pixels in font-size, using
relative units
like em or rem is a good practice.I hope you find it useful! By the way, the solution was great. ππ―
Enjoy coding, Stay Safe! π€
0 - @peredoprSubmitted over 1 year ago@RabicaTahirPosted over 1 year ago
@peredopr. π―Congratulations on completing the challenge !
π¬I have some suggestions about your code.
HTML π:
βͺ It's necessary for images to have short, descriptive alt text so screen reader users clearly understand the image's contents and purpose. Click and Change
<img src="./qr-code-component-main/images/image-qr-code.png">
βͺ It is advisable that you place all your main site content in a landmark element <main>. Wrap the body code in main tag. Click & Wrap
<div class="div-master">
βͺ Best practice is to ensure that the beginning of a page's main content starts with a h1 element. Click & Replace
<h2>Improve your frond-end skills by building your projects</h2>
CSS: π¨
πβͺ Instead of using pixels in font-size, using relative units like
em or rem
is a good practice.I hope you find it useful! By the way, the solution was great. ππ―
Enjoy coding, Stay Safe! π€
0 - @King0fBladesSubmitted over 1 year ago@RabicaTahirPosted over 1 year ago
Asalam o Alaikum! @King0fBlades. π―Congratulations on completing the challenge !
π¬I have some suggestions about your code.
HTML π:
βͺ It is advisable that you place all your main site content in a landmark element <main>. Wrap the body code in main tag. Click & Wrap
I hope you find it useful! By the way, the solution was great. ππ―
Enjoy coding, Stay Safe! π€
Marked as helpful1 - @Mariusq17Submitted over 1 year ago@RabicaTahirPosted over 1 year ago
Asalam o Alaikum! @Mariusq17. π―Congratulations on completing the challenge !
π¬ I have some suggestions about your code.
HTML π:
βͺ It is advisable that you place all your main site content in a landmark element <main>. Wrap the body code in main tag. Click & Wrap
<div class="main-container center">
CSS: π¨
πβͺ Instead of using pixels in font-size, using relative units like em or rem is a good practice.
I hope you find it useful! By the way, the solution was great. ππ―
Enjoy coding, Stay Safe! π€
Marked as helpful1 - @VictorR616Submitted over 1 year ago@RabicaTahirPosted over 1 year ago
Asalam o Alaikum! @VictorR616. π―Congratulations on completing the challenge !
π¬I have some suggestions about your code.
HTML π:
βͺ It is advisable that you place all your main site content in a landmark element <main>. Wrap the body code in main tag. Click & Wrap
βͺ Best practice is to ensure that the beginning of a page's main content starts with a h1 element. Replace this
CSS: π¨
πβͺ Instead of using pixels in font-size, using relative units like em or rem is a good practice.
I hope you find it useful! By the way, the solution was great. ππ―
Enjoy coding, Stay Safe! π€
Marked as helpful1