Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

qr-code-component-main

atiqurrehman123β€’ 10

@atiqurrehman123

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

RabicaTahirβ€’ 500

@RabicaTahir

Posted

Asalam o Alaikum! @atiqurrehman123. 🎯Congratulations on completing the challenge !

πŸ’¬I have some suggestions about your code.

HTML πŸ””:

β–ͺ It is advisable that you place all your main site content in a landmark element <main>. Wrap the body code in main tag. Click & Wrap the code

<div class="container">

β–ͺ Best practice is to ensure that the beginning of a page's main content starts with a h1 element. Replace this

<h5 class="card-heading">Improve your front-end <br />skills by building projects </h5>

β–ͺ Instead of using the <br> tag , you should use a semantic HTML element and the CSS margin or padding properties.

CSS: 🎨

πŸ“β–ͺ Instead of using pixels in font-size, using relative units like em or rem is a good practice.

I hope you find it useful! By the way, the solution was great. πŸ™ŒπŸ’―

Enjoy coding, Stay Safe! 🀞

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord