qr code design

Community feedback

• 

  RabicaTahir•500

  @RabicaTahirPosted over 1 year ago

  Asalam o Alaikum! @Mariusq17. 🎯Congratulations on completing the challenge !

  💬 I have some suggestions about your code.

  HTML 🔔:

  ▪ It is advisable that you place all your main site content in a landmark element <main>. Wrap the body code in main tag. Click & Wrap

  <div class="main-container center">

  CSS: 🎨

  📍▪ Instead of using pixels in font-size, using relative units like em or rem is a good practice.

  I hope you find it useful! By the way, the solution was great. 🙌💯

  Enjoy coding, Stay Safe! 🤞

  Marked as helpful

  1

  ---

  

  Ignat Marius•300

  @Mariusq17Posted over 1 year ago

  @RabicaTahir Thanks for the reply!

  This project, along with a few others on the account, were made a few months ago when I didn't really know much about the web, so they probably have various errors that I didn't know about then. But I gained more experience in the last months so that, I think, I make much better projects.

  I will try my best from now on to do the best I can in the subsequent projects, even if I may still have small lapses in concepts such as "site semantics" The point is that I'm still in the learning stage even at this moment, and I'm happy with what I'm doing, and I think that's what matters at this moment. 😁

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which lack landmark for a webpage

  ---

  • So fix it by replacing the <div class="card center"> element with the semantic element <main> along with <div class="attribution"> into a <footer> in your index.html file to improve accessibility and organization of your page.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

  ---

  • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1

  ---

  

  Ignat Marius•300

  @Mariusq17Posted over 1 year ago

  Thanks for the reply!

  This project, along with a few others on the account, were made a few months ago when I didn't really know much about the web, so they probably have various errors that I didn't know about then. But I gained more experience in the last months so that, I think, I make much better projects.

  I will try my best from now on to do the best I can in the subsequent projects, even if I may still have small lapses in concepts such as "site semantics" The point is that I'm still in the learning stage even at this moment, and I'm happy with what I'm doing, and I think that's what matters at this moment. 😁

  0