Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code component

Hristo Petrovβ€’ 120

@King0fBlades

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Hassia Issahβ€’ 50,670

@Hassiai

Posted

Replace<div class="container">with the main tag and <div class="attribution"> with the footer tag to fix the accessibility issues. click here for more on web-accessibility and semantic html

Give .content a margin value for all the sides, text-align: center and a font-size of 15px which is 0.9375rem, this will be the font-size of both p and h1. Give p a margin-top or h1 a margin-bottom value for the space between the text.

For a responsive content, replace the width in .container with max-width and give the ima a max-width of 100% instead of a width.

Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

Hope am helpful.

Well done for completing this challenge. HAPPY CODING

Marked as helpful

1
RabicaTahirβ€’ 500

@RabicaTahir

Posted

Asalam o Alaikum! @King0fBlades. 🎯Congratulations on completing the challenge !

πŸ’¬I have some suggestions about your code.

HTML πŸ””:

β–ͺ It is advisable that you place all your main site content in a landmark element <main>. Wrap the body code in main tag. Click & Wrap

I hope you find it useful! By the way, the solution was great. πŸ™ŒπŸ’―

Enjoy coding, Stay Safe! 🀞

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord