QR code component

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted over 1 year ago

  Replace<div class="container">with the main tag and <div class="attribution"> with the footer tag to fix the accessibility issues. click here for more on web-accessibility and semantic html

  Give .content a margin value for all the sides, text-align: center and a font-size of 15px which is 0.9375rem, this will be the font-size of both p and h1. Give p a margin-top or h1 a margin-bottom value for the space between the text.

  For a responsive content, replace the width in .container with max-width and give the ima a max-width of 100% instead of a width.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  1
• 

  RabicaTahir•500

  @RabicaTahirPosted over 1 year ago

  Asalam o Alaikum! @King0fBlades. 🎯Congratulations on completing the challenge !

  💬I have some suggestions about your code.

  HTML 🔔:

  ▪ It is advisable that you place all your main site content in a landmark element <main>. Wrap the body code in main tag. Click & Wrap

  I hope you find it useful! By the way, the solution was great. 🙌💯

  Enjoy coding, Stay Safe! 🤞

  Marked as helpful

  1