Design comparison
Community feedback
- @RabicaTahirPosted over 1 year ago
Asalam o Alaikum! @terza85. π―Congratulations on completing the challenge !
π¬I have some suggestions about your code.
HTML π:
βͺ It is advisable that you place all your main site content in a landmark element <main>. Wrap the body code in main tag. Click & Wrap the code
<div class="main-container">
βͺ Best practice is to ensure that the beginning of a page's main content starts with a h1 element. Replace this
<p class="heading">Improve your front-end skills by building projects</p>
βͺ It's necessary for images to have short, descriptive alt text so screen reader users clearly understand the image's contents and purpose.
<img src="images\image-qr-code.png" alt="" class="src">
CSS: π¨
πβͺ Instead of using pixels in font-size, using
relative units
like em or rem is a good practice.I hope you find it useful! By the way, the solution was great. ππ―
Enjoy coding, Stay Safe! π€
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord