font-weight: 400 changed nothing, something to worry about?
@fernandolapaz
Posted
Hi 👋, regarding your question:
CSS 🎨:
🔹font-weight of 400 and 700 are the default values for the normal and bold font respectively. That's why you won't see any changes.
I hope it’s useful 🙂
Regards,
Marked as helpful
@RabicaTahir
Posted
Asalam o Alaikum! @lucaspmarra. 🎯Congratulations on completing the challenge !
💬I have some suggestions about your code.
HTML 🔔:
▪ It's necessary for images to have short, descriptive alt text so screen reader users clearly understand the image's contents and purpose.
<img class="card-image" src="./images/image-qr-code.png" alt="">
CSS: 🎨
📍▪ Instead of using pixels in font-size, using relative units like em or rem is a good practice.
I hope you find it useful! By the way, the solution was great. 🙌💯
Enjoy coding, Stay Safe! 🤞
@lucaspmarra
Posted
@RabicaTahir I totally forgot about the alt text property. I agree with not using px, but, the style-guide informed in px, so I followed what was written there, I thought I would lose some punctuation or something.
@SlawekZet
Posted
Hey! It's only my preference, but I would delete the <main> tag and add margin: 1rem; (value is just an example) so it would scale nicely. Alternatively, you can delete div with a .card class and move everything to main + add the margin. Right now, after reaching approx 300 px brake point it starts to overlap - as shown on this screenshot - https://monosnap.com/file/QsyRUhlZAm7rQ6ykuCv4G8QwcUPpKl But still, it's only my preference :) other than that it's great!
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord
