Skip to content
OverviewSolutions
14
Comments
13

Mariem Ehab

@MaryEhbEgypt335 points

I’m a mysterious individual who has yet to fill out my bio. One thing’s for certain: I love writing front-end code!

I’m currently learning...

HTML CSS SASS JavaScript React Redux

Latest solutions

View more solutions

Latest comments

  • Mariem Ehab•335
    @MaryEhbPosted over 3 years ago

    The site looks pretty the same as the design and also you are the only one I reviewed who added the hover style to the three dots icons so great job 👏👏 I just have a few remarks:

    • There are more than one element that has the same id 'divsm' and that is not right because the ids are unique and can't be repeated for several elements. You can use classes instead
    • in the same elements as the previous point I noticed that the number of hours change as the user choice but the text (Last week) stay the same where it should also change between (last day - last week - last month)
    Marked as helpful
    0
  • Mariem Ehab•335
    @MaryEhbPosted over 3 years ago

    Nice work completing the challenge and the site works well on mobile and functions as needed I just found small things that need modification:

    • The most important one is that when the site is previewed the choice 'weekly' is highlighted while the data that appears is for daily so you should fix it
    • when the choice is changed the boxes disappear for a sec then appear again with the new data which may be annoying for some users
    • the three dots icon should be white when hovered

    Edit: I just saw your code and I really suggest that you don't change all of the inner HTML of the card element each time a choice is selected Instead you can change the inner html or text of the needed elements only which are of classes : title, current and previous

    Marked as helpful
    0
  • Mariem Ehab•335
    @MaryEhbPosted over 3 years ago

    You have done a great job this far this design can be really tricky I just have some recommendations hope they help

    • in filter time period class, the list should be selected and colored white when the site is previewed (weekly choice)
    • the vertical spacings need to be decreased
    • the title of boxs is white not gray
    • when boxs are hovered their color should change to a lighter one
    • the color of the three dots icon should be white when hovered
    0
  • Mariem Ehab•335
    @MaryEhbPosted over 3 years ago

    Wow! that looks perfect It looks identical to the design and it functions well You are really good 👍👍

    Marked as helpful
    1
  • Mariem Ehab•335
    @MaryEhbPosted over 3 years ago

    Well done this design can be a little tricky for some people and I liked how you dealt with the backgrounds of the boxs I just have some small modifications you may have not seen:

    • The frequency div should align its children in a row at small screens
    • the three dots icons color should change to white when hovered on
    • and also don't forget to make the frequency selected item be white and the other choices grey when you add js That's it hope this help and I will be waiting for the active state of the site
    Marked as helpful
    1
  • Mariem Ehab•335
    @MaryEhbPosted over 3 years ago

    Great job you have done a fantastic job this far I just have a recommendation on the email input example which I think it will be better if it appeared as a placeholder where the user won't need to delete it before typing his/her email

    Marked as helpful
    0
View more comments