Design comparison
Community feedback
- @MaryEhbPosted almost 3 years ago
Nice work completing the challenge and the site works well on mobile and functions as needed I just found small things that need modification:
- The most important one is that when the site is previewed the choice 'weekly' is highlighted while the data that appears is for daily so you should fix it
- when the choice is changed the boxes disappear for a sec then appear again with the new data which may be annoying for some users
- the three dots icon should be white when hovered
Edit: I just saw your code and I really suggest that you don't change all of the inner HTML of the card element each time a choice is selected Instead you can change the inner html or text of the needed elements only which are of classes : title, current and previous
Marked as helpful0 - @mooktarPosted almost 3 years ago
The choice 'weekly' is highlighted because I forget to remove its as an initial value at the fetchData() function. For this and the rest I'll fix as soon as possible.
Thank you for your suggestions.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord