Design comparison
SolutionDesign
Solution retrospective
any feedback or advice is appreciated :-)
Community feedback
- @grace-snowPosted over 3 years ago
Hi @MaryEhb
This looks good, well done!
My advice is pretty minor on this one, and more opinion than anything else
- make sure you remove animations for those who prefer-reduced-motion (look up the media query)
- personally I really don't like it when chunks of comtent animate into view, but that is just my opinion. There are times when animations are great and really spark joy, but in my experience these are usually subtle micro animations or transitions, or used to indicate interactive elements
- why have you used a submit input as your button? Html5 has a button element. I don't think there's any downside to using either, so it's just a choice. Again, I just prefer to use modern elements it they are available.
Keep. On. Coding! ☺
0@MaryEhbPosted over 3 years ago@grace-snow it's my first time to learn about (prefer-reduced-motion) topic I will definitely look it up 👍
I have no idea why I used submit input instead of a button 🤔😂
Thank you so much for your advices😍
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord