Akhlak Hossain Jim
@Akhlak-Hossain-JimAll comments
- @middlemineSubmitted over 1 year ago@Akhlak-Hossain-JimPosted over 1 year ago
Hey, You have done a great job completing the challenge. Here is some of my suggestions to make it more better.
- remove the margin from all side in the mobile view (
margin: 0;
) - In the mobile view try adding
width: 100%;
- You can start your from
576px
(standard mobile view of bootstrap)
0 - remove the margin from all side in the mobile view (
- @Mudi-IgbinobaSubmitted over 2 years ago
I need feedback on best practices and accessibility and anything else
@Akhlak-Hossain-JimPosted over 2 years agoHi there, great work so far,
But here are some things you can do to improve your code.
- add
line-height: 100%;
at your.rare-btn
that way it will be a proper circle. - add can add an
if else
statement to check if someone has selected a rating or not, if so you change the card or do nothing that would be great
Keep up the good work. Happy coding:)
Marked as helpful0 - add
- @im-voracitySubmitted over 2 years ago
Any feedbacks are welcome!
@Akhlak-Hossain-JimPosted over 2 years agoGreat work so far.
Here are some of my suggestions,
- consider using column gap as well for responsiveness
- instead of hard-coded values like
px
, try using relative values likeem
,rem
,%
etc making the site responsive
And remember practice will make it better so practice more. Happy coding :)
1 - @brainwinsSubmitted over 2 years ago
Which rules do you follow on when to use rems, %, or vws?
How low of a width resolution should I target?
@Akhlak-Hossain-JimPosted over 2 years agoGreat work so far. Everything looks good on the website.
Here is some of my suggestion,
- I found
%
is best for this kind of scenario where calculation involved - and for the resolution, you should consider using relative values like
em
,rem
, and more or you can use CSS functions likemin()
,max()
,minmax()
check this and this resources for reference. - check for typos in code like
sectiom
Keep coding everything just need a bit practice. Happy coding :).
1 - I found
- @anthonygedeonSubmitted over 2 years ago
Would you say this is a good example of the BEM methodology?
@Akhlak-Hossain-JimPosted over 2 years agoGreat work so far, but
- consider using
main
tag for the card container that would be a great practice - add some space in the mobile view
- try using
h1
at first and thenh2
,h3
and all
Other than that everything looks good. Happy coding:).
1 - consider using
- @ttaammaarrSubmitted over 2 years ago
Is there a way to align all buttons to be at the same vertical position? The paragraphs contain a different amount of words, when resizing the browser, this causes some alignment issues with the buttons. Any tips or advice is appreciated!
@Akhlak-Hossain-JimPosted over 2 years agoNice work. For that you can do:
- set a fixed bottom padding,
- take a div with
display: flex;
forp
and thebutton
and - make
flex-direction: column; justify-content: space-between;
or
- in
section
adddisplay: flex; flex-direction: column;
, - select
img
and addwidth:64px;height:auto;
- in
button
addmargin-top:auto;
and it should always stay in the same position.
Happy coding :)
Marked as helpful0 - @safXcodeSubmitted over 2 years ago
hello, This is my solution to the Huddle landing page with a single introductory section challenge
@Akhlak-Hossain-JimPosted over 2 years agoHey, Great work so far,
add
title
attribute to thei
tag to solve the accessibility issues.Happy coding :)
Marked as helpful0 - @esteban2368Submitted over 2 years ago
Hi everyone,
i have a question: The size container (width and height) is correctly. I appreciate your feedback
@Akhlak-Hossain-JimPosted over 2 years agoGreat work so far. But here is some of my suggestions to fix your issues,
- try adding
alt
text in the image and try adding in every image. - remove
action
attribute for now as you are not doing anything with that. So remove that your issues should go away.
Happy coding:)
Marked as helpful0 - try adding
- @mv805Submitted over 2 years ago
Please, any kind of feedback is welcom.
@Akhlak-Hossain-JimPosted over 2 years agoHey Matt, I just reviewed your code and preview, great work so far, and here are some of my suggestions:
- try to add some padding in the
.main-space
class. - instead of
div
in<div class="main-space">
try usingmain
tag here. - instead of
<div class="attribution">Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a>.Coded by <a href="#">Your Name Here</a>.</div>
use<footer class="attribution">Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a>.Coded by <a href="#">Your Name Here</a>.</footer>
. - try using CSS variables.
Happy coding :)
1 - try to add some padding in the
- @renzpaloSubmitted over 2 years ago
This is a mobile-first approach
@Akhlak-Hossain-JimPosted over 2 years agohey, renzzzz. great work so far.
I just saw the preview and the code, here are some of my suggestions.
- try first heading as
h1
- try learning and using CSS variables.
- try learning Sass or some frameworks/libraries.
Happy coding :)
0 - try first heading as
- @adam434512Submitted over 2 years ago
How to put that background top and bottom exactly just like they look in design view
@Akhlak-Hossain-JimPosted over 2 years agoGreat work adam. I just saw through your code and the live preview. It looks great. Here is my feedback:
- try not to use
div
directly in the body, like<div class="social-container">
useheader
main
whatever suits best in that case. - try using CSS variables for color and stuffs.
Happy coding:)
Marked as helpful0 - try not to use
- @AndyAshleySubmitted over 2 years ago
Feedback welcome
@Akhlak-Hossain-JimPosted over 2 years agoGreat work Andy. I just saw your code and live preview. It looks so good to me just try doing the following:
- add some top padding to the body it looks stacked in the mobile view.
- try leaning new things like sass/less and/or css frameworks.
Happy coding :)
Marked as helpful1