Responsive NFT card using Sass

Community feedback

• 

  CyrusKabir•1,885

  @CyrusKabir

  Posted about 3 years ago

  hello my dear friend ♥ you did good on this challenge but you need get close to main design and here some tips :

  • in main design card bottom padding it's less than in your card
  • also the h1 default font-size is to much for this card title
  • adding some line-height to body (for that text content under title)
  • your img have impact on your card dimension (because of that absolute width and height you add) if you remove it you can see there is not even needed to be there
  • and it's a good thing to use a file structure when you use sass/scss it's make your code clean, readable, reusable, maintainable , and much more benefits also you can check this links for sass file structure 2 way to structure your sass, structuring your sass, simple sass structure

  01

  Marked as helpful
• 

  Akhlak Hossain Jim•1,325

  @Akhlak-Hossain-Jim

  Posted about 3 years ago

  You have done great work so far.

  Try implementing these:

  • add alt attribute in images and don't keep it empty.
  • go h1 to h6 serially, meaning use first heading tag as h1 then if you need to go down, do not go to h3 or h4 go to h2 first then following and repeat h1 or any one of those but keep it in sequence.
  • try using sass variable.

  Happy coding :)

  01

  Marked as helpful