HTML CSS | QR CODE COMPONENT

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Renzo, great work!

  But section go inside main tag not the other way around and instead of using px try to use relative units of measurement -> read here

  Overall you did well 😉 Hope this help and happy coding!

  Marked as helpful

  0
• 

  Akhlak Hossain Jim•1,325

  @Akhlak-Hossain-JimPosted over 2 years ago

  Great work Ranzo. Her is my recomandations to solve some of your issues.

  • try wraping <div class="attribution">Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a>. Coded by <a href="#">Renzo Alvarez</a>.</div> this in a <footer> tag.
  • don't use <section><main>...</main></section> instead use <main><section>...</section></main>.

  your other html css code looks good to me so try learning sass and frameworks to move forward.

  Happy coding :)

  Marked as helpful

  0

  ---

  

  Renzo Alvarez Arevalo•280

  @ralvarezrenzoPosted over 2 years ago

  @Akhlak-Hossain-Jim Thank you very much for letting me know, now I will correct the errors of the footer > attribution and section > main, greetings.

  0