Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

HTML CSS | QR CODE COMPONENT

@ralvarezrenzo

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Feedback welcome :)

Community feedback

Travolgi πŸ•β€’ 31,420

@denielden

Posted

Hi Renzo, great work!

But section go inside main tag not the other way around and instead of using px try to use relative units of measurement -> read here

Overall you did well πŸ˜‰ Hope this help and happy coding!

Marked as helpful

0
Akhlak Hossain Jimβ€’ 1,325

@Akhlak-Hossain-Jim

Posted

Great work Ranzo. Her is my recomandations to solve some of your issues.

  • try wraping <div class="attribution">Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a>. Coded by <a href="#">Renzo Alvarez</a>.</div> this in a <footer> tag.
  • don't use <section><main>...</main></section> instead use <main><section>...</section></main>.

your other html css code looks good to me so try learning sass and frameworks to move forward.

Happy coding :)

Marked as helpful

0

@ralvarezrenzo

Posted

@Akhlak-Hossain-Jim Thank you very much for letting me know, now I will correct the errors of the footer > attribution and section > main, greetings.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord