@yiorgosbagakis
@MamdohSamer
Submitted
What are you most proud of, and what would you do differently next time?
using JavaScript in this project
What challenges did you encounter, and how did you overcome them?
using JavaScript in this project
What specific areas of your project would you like help with?
this page can be like an article or ads for any service
@yiorgosbagakis
Posted
Nice tryhowever I see that the elements are a bit off. The picture the elements around the share button and the tooltip doesn't include the social media icons.
Interesting use of if statement on your JS code.
Marked as helpful
@Chikairo
Submitted
@yiorgosbagakis
Posted
Very nice work with clean and well structured html code.
Possibly adding a <picture> tag around the image avatars would help semanticly?
The only visual issue I see is that on some middle range screen widths the quotation mark icon is off the card. This should be adjusted.
What are you most proud of, and what would you do differently next time?
Learned bascics of making responsive layout using grid technique.
@yiorgosbagakis
Posted
Great work and pretty accurate! Just need to add the orange border (at the moment you are using two cards with red border colour).
Marked as helpful
@jetobe95
Submitted
What are you most proud of, and what would you do differently next time?
@yiorgosbagakis
Posted
Excellent work!
@Ejiro-Frances
Submitted
What are you most proud of, and what would you do differently next time?
I am proud of how much I learnt in the course of this project.
What challenges did you encounter, and how did you overcome them?
One of the challenges I had was using the font provided in the kit provided, I got the font from google font online since I was not sure why the one provided only gave me bold fonts.
Another challenge was trying to choose the ideal measurement for margins and paddings that would present the page as close to the designer's as much as possible.
What specific areas of your project would you like help with?
I would like a review of what I have done and any pointers to make it better would be greatly appreciated.
@yiorgosbagakis
Posted
Very good work! It is very close to the original design and the only obvious issues I see are:
The headings look bolder than the original. Maybe you should try smaller 'font-weight' (500?)
The header image looks a bit larger than the original
Regarding the semantic html use I would add a header section and use more section elements.
Marked as helpful
@YosefHayim
Submitted
@yiorgosbagakis
Posted
Very good work. I would try to match better the sizes of the elements to the original design. Eg the main container seems quite smaller and packed compared to the original.
@Trianapetit
Submitted
What are you most proud of, and what would you do differently next time?
Un muy buen reto, para iniciar
What challenges did you encounter, and how did you overcome them?
Los desafios comprender el modelo de caja, display: block, display: flex.
@yiorgosbagakis
Posted
This is a very good and accurate solution. Maybe some semantic HTML would improve it, because there are a lot of 'div' elements at the moment.
@yiorgosbagakis
Posted
Quite good solution but the card is smaller and in particular the fonts.. That makes them less legible.
There are too many divs used so some semantic elements could be used more.
Overall very good work the code is well structured and it works well in all screen sizes
