Skip to content
OverviewSolutions
7
Comments
7
tailor-made-god
@tailor-made-god

All comments

  • ManPP•130
    @WhitezerDSubmitted about 2 months ago
    What are you most proud of, and what would you do differently next time?

    Leaning how to use grid system especially grid-template-areas

    What challenges did you encounter, and how did you overcome them?

    When resizing the text on small screen to larger screen, My paragraph on grid items were overflow out of the container. My solution were to not changing the font-size but that was a bad one.

    What specific areas of your project would you like help with?

    Everything as this community will point out.

    Testimonials Grid Section

    1
    tailor-made-god•120
    @tailor-made-godPosted about 2 months ago

    Your website almost matching the design. expect few things, the sizes are different and the grid is not centered horizontally because of its size.

    To fix this,

    • fix the grid size and use the max width on the grid parent
    • then align horizontally with place content
    • resize the icon and author name with smaller values
    • inside the div resize the paragraph elements with matching value
    • to align the lines to match the design use max width property again in percentage because its works well in mine

    Basically the size of the elements are bigger than design.

    Other than that your project matching the design very closely and the code you written is clean.

    0
  • tailor-made-god•120
    @tailor-made-godPosted about 2 months ago

    Your website almost matching the design but few mistakes here and there. And your code is very clean and readable.

    To fix the issues

    • change the color of the card to white
    • resize the header text in mobile to lower
    • change the h1 tag font weight to 200 and wrap the second half in <strong > tag
    • change the card size and icon size to lower to match the mobile design
    • add margin on top of the header in any way you like.

    Other than these few things your project is almost matching the design and your code is super readable.

    0
  • tailor-made-god•120
    @tailor-made-godPosted about 2 months ago

    Your project almost matching the design but not entirely.

    #To fix the some of the error

    • Try to use picture tag while using image and specify separate mobile and desktop image sources
    • Resize the container card div to equal the image size or vise versa.
    • Align the space between elements using margins or padding.

    I can not see your live site, please put separate link while submitting the projects.

    Other than that your project almost matching the design.

    0
  • tailor-made-god•120
    @tailor-made-godPosted about 2 months ago

    Your css code and containers naming is very clean. Css code is very readable.

    Font colors and some of other colors also not matching the design and Mobile website does not match the design. To fix that fill the image to the full container width and remove any padding or margin.

    Other than that your website matching the design and the code is very clean and readable.

    0
  • tailor-made-god•120
    @tailor-made-godPosted about 2 months ago

    Your website matches the design very well and markup is well written.

    But in the mobile site the card height is too high, you can fix that by doing fixed height. And font weights are not matching the design.

    But other than that your desktop site matches the design very closely.

    Marked as helpful
    2
  • Alrn•50
    @Annabelle-LrnSubmitted about 2 months ago
    What are you most proud of, and what would you do differently next time?

    I tried to apply comments received on previous challenge (using rem instead of px, BEM methodology). probably create a reset css sheet if the project is larger.

    Css Grid

    1
    tailor-made-god•120
    @tailor-made-godPosted about 2 months ago

    Always put alt text in an image, except if its an icon. And always specify the width and height of an image.

    Your css styles looks pretty good and super readable.

    Your code is great. but inside the div Elements try to use flex instead of grid. In my case its is easy with flex to deal with inside elements.

    Marked as helpful
    0