Feedback is very appreciated!
Latest comments
- @synnestormSubmitted 3 days agoWhat specific areas of your project would you like help with?@st0272Posted 3 days ago
Your code is generally good. However, using the root-relative size unit (rem) is more desirable.
0 - @jose-beltranSubmitted 20 days ago@st0272Posted 19 days ago
Your code is generally well-structured, but several issues and areas for improvement in terms of semantics, accessibility, and organization. Below is my opinion for improvement.
Use of
<p>
for titlesThe
<p>
tag is used for headings like "Reliable, efficient delivery" and "Powered by Technology", which should be in<h1>
and<h2>
respectively for better semantics.Missing
alt
attributes in imagesThe <img> tags have an empty
alt=""
, which is not good for accessibility.Improper nesting of divs
The
content-cards-two
div is nested inside the.content-cards
but is structured inconsistently. It appears that all.card
elements should be direct children of.content-cards
for better alignment and flexibility. Using grid to style this four-card layout is efficient.I hope my advice will be helpful for your coding. Keep up the good work!
0 - @erntTt94Submitted 4 months agoWhat specific areas of your project would you like help with?
Any feedback appricated...
@st0272Posted 4 months agoYour JavaScript(React) code is well-written, but there are several areas for improvement in the HTML and CSS:
- The design is larger than specified in the design file.
- It's preferable to use
class
instead ofid
for styling and structure. - The desktop design is incomplete. Wrap the image and content items in
<div class="card">
and usedisplay: flex
ordisplay: grid
to align the items properly.
I hope my advice will be helpful for your coding. Keep up the good work!
1 - @andreshinostrozaSubmitted 5 months ago@st0272Posted 5 months ago
Your code is well-structured, but there are several points for improvement:
1. Accuracy of Sizes
- Font sizes: Each font size is 1 or 2 pixels larger than the design file.
- Margin: The margin size for the text "London, United Kingdom" is slightly wider than expected.
2. Unnecessary CSS Styles
h1
andh2
classbg-c
: Theprincipal
class already applies the samebackground-color: var(--Gray-800)
, making this redundant.enlace
class: Thecursor: pointer
style is unnecessary since it is the default behavior for anchor (<a>
) tags.
I think it could be even better with a little more attention to detail. Keep up the good work!
0 - @zololadeSubmitted 6 months ago@st0272Posted 6 months ago
Your code is well-structured, but there are several important points for improvement:
- The desktop design is slightly smaller compared to the original design. Please make sure to measure the padding, image sizes, and other elements correctly.
- The mobile version of the design is the same as the desktop version. Please create a mobile version using appropriate media queries.
- Ensure that the
h4
tag with the.header__caption
class follows the appropriate heading structure. It's better not to use anh4
tag before anh1
. It might be better to use ap
tag instead of anh4
. - The
h2
andh3
tags inside thesection
tag with.main__pricetag
class might confuse the document hierarchy. You could consider using<span>
with appropriate class names and using<div>
tag or<p>
tag instead of<section>
tag.
I think your coding skills could be even better. and Keep up the good work!
0 - @sudo-mehediSubmitted 6 months ago@st0272Posted 6 months ago
The HTML and CSS code you provided is well-structured but could benefit from a few improvements for better accessibility, maintainability, and design.
-
Ensure that the <h4> tag follows the appropriate heading structure. It's better not to use an <h4> tag before an <h1>. It might be better to use a <p> tag instead of an <h4>.
-
Inline styles are not good for maintainability, so it's better to use external CSS files.
-
The
.card
doesn't have a border. -
The content size on the desktop version is slightly smaller compared to the design file. Please make sure to measure the padding, image sizes, and other elements correctly.
I think it could be even better with a little more attention to detail. Keep up the good work!
0 -