Design comparison
SolutionDesign
Community feedback
- @st0272Posted 2 months ago
Your code is well-structured, but there are several important points for improvement:
- The desktop design is slightly smaller compared to the original design. Please make sure to measure the padding, image sizes, and other elements correctly.
- The mobile version of the design is the same as the desktop version. Please create a mobile version using appropriate media queries.
- Ensure that the
h4
tag with the.header__caption
class follows the appropriate heading structure. It's better not to use anh4
tag before anh1
. It might be better to use ap
tag instead of anh4
. - The
h2
andh3
tags inside thesection
tag with.main__pricetag
class might confuse the document hierarchy. You could consider using<span>
with appropriate class names and using<div>
tag or<p>
tag instead of<section>
tag.
I think your coding skills could be even better. and Keep up the good work!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord