Skip to content
OverviewSolutions
41
Comments
23
P
John Norman
@norman02

All comments

  • John Norman•880
    @norman02Posted almost 3 years ago

    Congrats on completing this challenge. It looks pretty good! The only suggestion I would make is to fix the accessibility issues listed in the report. Happy coding!

    Marked as helpful
    0
  • John Norman•880
    @norman02Posted over 3 years ago

    You're right, thank you for the suggestions!

    0
  • John Norman•880
    @norman02Posted over 3 years ago

    Thanks for the feedback!

    0
  • John Norman•880
    @norman02Posted almost 4 years ago

    Thanks! I'll make that change.

    0
  • John Norman•880
    @norman02Posted almost 4 years ago

    Thank you for the suggestion!

    0
  • John Norman•880
    @norman02Posted about 4 years ago

    It is showing up fine for me on both Chrome and Firefox. Only thing I would suggest is to set outline: none; this will remove the blue box that shows up when you click the button.

    0
  • Jan•500
    @eljasiuSubmitted about 4 years ago

    Hello guys, this is my solution to this challange. I hope you like the smooth way the bar with social media icons appears. I had some struggles with that. 'transition' property didn't seem to work with JavaScript, so I had to use 'setTimeout' function to make the animation work. I hope you like this method. I would be very grateful for your thoughts on this projects. Hava a great day, Jan

    JavaScript + Transition combination

    2
    John Norman•880
    @norman02Posted about 4 years ago

    It looks good, I like the transition delay animation. Two things I noticed: there is no shadow on the main element. The share element doesn't transition back to default state.

    1
  • John Norman•880
    @norman02Posted about 4 years ago

    It looks great! I wasn't able to view your code so can't comment on that.

    0
  • John Norman•880
    @norman02Posted about 4 years ago

    Thanks for posting this! I'm just starting to use Sass over raw CSS and yours is a great example of SCSS structure.

    0
  • John Norman•880
    @norman02Posted over 4 years ago

    This looks pretty good. A couple things the background color for the bubble should be #FFF. There should be a background image. Looks like you got all the hard parts right.

    1
  • John Norman•880
    @norman02Posted over 4 years ago

    I really like this! One minor suggestion, if you add name="email" to the email input it allows many browsers to suggest the user's stored email addresses.

    0
  • John Norman•880
    @norman02Posted over 4 years ago

    The main thing I see is that the button should have a white background

    0