Skip to content
OverviewSolutions
12
Comments
31
P
Momin Riyadh
@momin-riyadh

All comments

  • P
    Momin Riyadh•370
    @momin-riyadhPosted over 1 year ago

    Good Job! It should be responsive and vertically centered, and aligned!

    Moreover, you need to subscribe, and to get started, follow this link. It'll take you to the course's website, where you can sign up and start your JavaScript learning journey. Don't worry; the course is beginner-friendly and designed to help you grasp the fundamentals.

    0
  • Steven Jarvis•110
    @sjarvisSubmitted over 1 year ago

    This solution uses no JS, instead going for a pure CSS mobile menu. The drawback is that it uses :has, which is unsupported by Firefox. I did not craft a fallback for Firefox.

    There is only one breakpoint (at 1024px) for responsiveness. Basically, it toggles between a desktop/tablet view and a mobile/small tablet view.

    Fun project.

    responsive news homepage

    1
    P
    Momin Riyadh•370
    @momin-riyadhPosted over 1 year ago

    Good Job! Why did you add a flex property style in the body tag? Suppose you have many pages that will be rendered in the body tag. Then flex property may not be necessary for the rest!

    body {
min-height: 100dvh;
display: flex;
justify-content: center;
}

    Moreover, you need to subscribe, and to get started, follow this link. It'll take you to the course's website, where you can sign up and start your JavaScript learning journey. Don't worry; the course is beginner-friendly and designed to help you grasp the fundamentals.

    0
  • P
    Momin Riyadh•370
    @momin-riyadhPosted over 1 year ago

    Good Job! It would be best if you focused on design. Did you check the corner border radius and vertical centre entire div in the Desktop

    Moreover, you need to subscribe, and to get started, follow this link. It'll take you to the course's website, where you can sign up and start your JavaScript learning journey. Don't worry; the course is beginner-friendly and designed to help you grasp the fundamentals.

    0
  • P
    Momin Riyadh•370
    @momin-riyadhPosted over 1 year ago

    Good Job! It could be better in terms of button hover animation and footer text! Moreover, you need to subscribe, and to get started, follow this link. It'll take you to the course's website, where you can sign up and start your JavaScript learning journey. Don't worry; the course is beginner-friendly and designed to help you grasp the fundamentals.

    0
  • P
    Momin Riyadh•370
    @momin-riyadhPosted over 1 year ago

    I just checkout your repository, and it shows me almost 90% code you write in JavaScript! Brilliant Job! I can say you need to focus a little bit on design/UI/UX. Also, your animations are cool!

    Moreover, you need to subscribe, and to get started, follow this link. It'll take you to the course's website, where you can sign up and start your JavaScript learning journey. Don't worry; the course is beginner-friendly and designed to help you grasp the fundamentals.

    Marked as helpful
    0
  • Yafi Abyan•40
    @abyanfalahSubmitted over 1 year ago

    My main focus is responsive design so please have a look on the live site and tell me if there is anything wrong with the responsiveness.

    I use flex-column for the mobile design and turn it into flex-row-reverse for the desktop design, I wonder if it's the right way to do so. Please let me know the best practice for this kind of design.

    There is some gap on the bottom of screen on the signup screen when I check the site from my phone. Tried to tweak some of the tailwind classes but got no clear idea why the gap exists. Please let me know if spot the cause.

    Feedback on any aspect is welcome! Thank you!

    Responsive newsletter signup HTML Vue TailwindCSS

    #vue#tailwind-css
    2
    P
    Momin Riyadh•370
    @momin-riyadhPosted over 1 year ago

    Good Job. I can see you fully consume the tailwind CSS feature! A small project shouldn't use Tailwind CSS.

    Moreover, you need to subscribe, and to get started, follow this link. It'll take you to the course's website, where you can sign up and start your JavaScript learning journey. Don't worry; the beginner-friendly system is designed to help you grasp the fundamentals.

    0
  • P
    Momin Riyadh•370
    @momin-riyadhPosted over 1 year ago

    Good approach! It could be better! Design and Aesthetics

    • the bottom horizontal bar shouldn't show
    • not responsive
    • navigation and body do not align
    • design and aesthetics should improve

    Moreover, you need to subscribe, and to get started, follow this link. It'll take you to the course's website, where you can sign up and start your JavaScript learning journey. Don't worry; the course is beginner-friendly and designed to help you grasp the fundamentals.

    Marked as helpful
    0
  • Mohammed Nibras Abdulla•120
    @nibess1Submitted over 1 year ago

    My 4th ever project (one of my earlier ones, yet final ones), Site is slightly more responsive than the social proofs page(3rd project) I made.

    Huddle landing page

    1
    P
    Momin Riyadh•370
    @momin-riyadhPosted over 1 year ago

    Perfect and Good Job! It should not scroll on desktop and also in mobile view!

    Moreover, you need to subscribe, and to get started, follow this link. It'll take you to the course's website, where you can sign up and start your JavaScript learning journey. Don't worry; the course is beginner-friendly and designed to help you grasp the fundamentals.

    0
  • P
    Momin Riyadh•370
    @momin-riyadhPosted over 1 year ago

    Good Job! It would be best to consider specific widths for desktops and design guidelines for aesthetic and visual appearance/hierarchy.

    Moreover, you need to subscribe, and to get started, follow this link. It'll take you to the course's website, where you can sign up and start your JavaScript learning journey. Don't worry; the course is beginner-friendly and designed to help you grasp the fundamentals.

    0
  • P
    Momin Riyadh•370
    @momin-riyadhPosted over 1 year ago

    Perfect! You also used JavaScript match matchMedia() Why not CSS Media Query?

    Moreover, you need to subscribe, and to get started, follow this link. It'll take you to the course's website, where you can sign up and start your JavaScript learning journey. Don't worry; the course is beginner-friendly and designed to help you grasp the fundamentals.

    0
  • JuvoGenesis👾•2,010
    @AkoToSiJeromeEhSubmitted over 1 year ago

    Hi guys, I just want to share that I have accomplished the 3-column preview card component. So far, so good! It has been enjoyable and fun to work on, especially because I made some modifications to the background colors, hover effects, and animations. That's all! Happy coding, everyone, and mabuhay!

    3-column preview card component | React | CSS | Add some modification

    #react
    4
    P
    Momin Riyadh•370
    @momin-riyadhPosted over 1 year ago

    It could be better in terms of transition and animation smoothness! You should focus on scrimba courses and practice more and follow other developer code

    Moreover, you need to subscribe, and to get started, follow this link. It'll take you to the course's website, where you can sign up and start your JavaScript learning journey. Don't worry; the beginner-friendly system is designed to help you grasp the fundamentals.

    0
  • Whitegod Kingsley•450
    @iamwhitegodSubmitted over 1 year ago

    Hello guys,

    I just completed the Job Listing with Filtering challenge. I want to get feedback on filtering logic, state management, areas needing optimisation, and the overall component architecture.

    Job Listing with Filtering

    #sass/scss#react
    1
    P
    Momin Riyadh•370
    @momin-riyadhPosted over 1 year ago

    Good Job ! In mobile filter should adjust the z-index.

    You should focus on scrimba courses and practice more and follow other developer code

    Moreover, you need to subscribe, and to get started, follow this link. It'll take you to the course's website, where you can sign up and start your JavaScript learning journey. Don't worry; the beginner-friendly system is designed to help you grasp the fundamentals.

    0