Design comparison
Solution retrospective
I would greatly appreciate your feedback on my project so that I can make improvements. Thank you in advance for taking the time to share your thoughts with me.
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
LABELS 🔖:
input
elements wants alabel
associated with it
- A
<label>
is used to create a caption for a form control. The<label>
can be associated with a form control either implicitly by placing the control element inside the label element, or explicitly by using the for attribute
- Effective form
labels
are required to make forms accessible. The purpose ofform
elements such ascheckboxes
,radio
buttons,input
fields, etc, is often apparent to sighted users
- Even if the
form
element is not programmatically labeled. Screen readers users require useful formlabels
to identifyform
fields, So here usingaria-label="{values}"
attributes forinput
is enough to be accessible
- Example:
<input type="text" aria-label="First Name" placeholder="First Name" id="first-name" name="first-name">
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful1 - @waldekglazPosted over 1 year ago
Hi
It looks good.
You could use
type="tel"
for Phone Number field and add some validation to make it perfect.Marked as helpful1 - @momin-riyadhPosted over 1 year ago
If I have to learn something from you, it's vanilla Javascript Perfect! Good Job
Moreover, you need to subscribe, and to get started, follow this link. It'll take you to the course's website, where you can sign up and start your JavaScript learning journey. Don't worry; the beginner-friendly system is designed to help you grasp the fundamentals.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord