Design comparison
Solution retrospective
My main focus is responsive design so please have a look on the live site and tell me if there is anything wrong with the responsiveness.
I use flex-column
for the mobile design and turn it into flex-row-reverse
for the desktop design, I wonder if it's the right way to do so. Please let me know the best practice for this kind of design.
There is some gap on the bottom of screen on the signup screen when I check the site from my phone. Tried to tweak some of the tailwind classes but got no clear idea why the gap exists. Please let me know if spot the cause.
Feedback on any aspect is welcome! Thank you!
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
BODY MEASUREMENTS 📐:
- The
h-screen
utility class is used to defineheight: 100vh
, But we want to usemin-height: 100vh
forbody
instead ofheight: 100vh
. Setting theheight: 100vh
may result in the component being cut off on smaller screens.
- For example; if we set
height: 100vh
then thebody
will have100vh
height no matter what. Even if the content spans more than100vh
.
- But if we set
min-height: 100vh
then thebody
will start at100vh
, if the content pushes thebody
beyond100vh
it will continue growing. However if you have content that takes less than100vh
it will still take100vh
in space.
- So we want to use
min-h-screen
utility class to definemin-height: 100vh
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
0 - @momin-riyadhPosted over 1 year ago
Good Job. I can see you fully consume the tailwind CSS feature! A small project shouldn't use Tailwind CSS.
Moreover, you need to subscribe, and to get started, follow this link. It'll take you to the course's website, where you can sign up and start your JavaScript learning journey. Don't worry; the beginner-friendly system is designed to help you grasp the fundamentals.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord