It's a nice card that looks different in mobile and desktop views. it's not just because of the layouts but also because of the change in the background image.
Overall it's a nice card I loved developing this card.
Awesome work!!! Keep going. Do focus on minute details while implementing responsive designs. Especially padding and margins.
In this project, I could learn so many things like background linear-gradient property. I have come across margin collapsing there was a problem to solve then I have found the solution for margin collapsing. First, it was a problem to convert the mobile layout to a desktop layout then I used Flex and some of the CSS rules then I finally completed the project.
Hi Nishant, Please consider following points:
Great work.
I have learned many new things from this project, like adding two images for different layouts per their needs and making the content centered vertically on the page.
Hi Nishant, Awesome work!!! However I would like to highlight following points to consider:
Felt little difficult for creating responsive site.
Hi Prem, Great efforts. I would like to suggest the following points.
These were the questions that accompanied my original submission. They were answered but the more the merrier I say. Thanks!
Question 1: I set the dimensions of the component card using pixels like so: width: 320px; height: 496px; I think I was worried if using fixed dimensions it wouldn't be truly responsive. Is that a misconception or would it be more appropriate to use a different unit like percent or rem instead of px?
Question 2: Did I successfully build it? I was surprised that the dimensions were the same for both the mobile and desktop versions. Did it just work out that way or have I made a mistake?
Question 3: Other than adding an alt tag to the image, I wasn't sure what other accessibility features I could include. Please let me know if I missed any - I'm still just learning the basics of accessibility.
Thank you in advance for your time and feedback. This is my first submission to Frontend Mentor.
Answer to Question 1: In my opinion px is perfectly fine. Avoid using height wherever possible. Answer to Question 2: By applying height 100vh you are introducing scroll behavior to your page. Try implementing the following solution (https://stackoverflow.com/a/27869108/9569049) to center the card.
Answer to Question 3: Use html5 semantic <main> tag instead of <div class="container"> to fix your accessibility issue.
I would be really happy for any feedback as that is how I am learning. Thank you.
