Skip to content
OverviewSolutions
12
Comments
6

Deepak K J

@kjdeepakIndia430 points

Front End Engineer - ( Angular ) Well versed with HTML, CSS, JavaScript, Typescript, and Angular

Latest solutions

View more solutions

Latest comments

  • Deepak K J•430
    @kjdeepakPosted over 1 year ago

    Awesome work!!! Keep going. Do focus on minute details while implementing responsive designs. Especially padding and margins.

    1
  • Deepak K J•430
    @kjdeepakPosted almost 2 years ago

    Hi Nishant, Please consider following points:

    1. Fix border radius in desktop view.
    2. Use right font family as per given design.

    Great work.

    0
  • Deepak K J•430
    @kjdeepakPosted almost 2 years ago

    Hi Nishant, Awesome work!!! However I would like to highlight following points to consider:

    1. Mobile view card layout needs to be center aligned.
    2. Fix line height for paragraph.
    3. Use proper font family.
    4. Fix button shadow.
    Marked as helpful
    0
  • prem•50
    @prem8097Submitted almost 3 years ago

    html and css

    #accessibility#bootstrap#django#react#emotion
    1
    Deepak K J•430
    @kjdeepakPosted almost 3 years ago

    Hi Prem, Great efforts. I would like to suggest the following points.

    1. Please use a self-explanatory CSS selector name in your CSS file else it will become difficult for other developers to follow your work.
    2. Don't ignore accessibility issues reported against your solution.
    Marked as helpful
    0
  • Deepak K J•430
    @kjdeepakPosted almost 3 years ago

    Answer to Question 1: In my opinion px is perfectly fine. Avoid using height wherever possible. Answer to Question 2: By applying height 100vh you are introducing scroll behavior to your page. Try implementing the following solution (https://stackoverflow.com/a/27869108/9569049) to center the card.

    Answer to Question 3: Use html5 semantic <main> tag instead of <div class="container"> to fix your accessibility issue.

    Marked as helpful
    0
  • Deepak K J•430
    @kjdeepakPosted almost 3 years ago
    1. Remove unnecessary text.
    2. Check for mobile responsiveness
    3. Use a CSS methodology while using vanilla CSS for your project so this will help you in maintaining styling rules in complex projects.
    4. Check for word breaks and font size.
    Marked as helpful
    0