Skip to content
OverviewSolutions
12
Comments
42
Rimka
@karimfilali

All comments

  • Rimka•600
    @karimfilaliPosted over 2 years ago

    Hello! Good work with this project. Looking at your solution, I would like to suggest that you add the second parameter to the fetch method in your App.js file to enable it fetch new advice every time a user clicks the dice button. You could add something like this: fetch(url, { cache: "no-cache", }); Hope this was helpful..

    1
  • Rimka•600
    @karimfilaliPosted over 2 years ago

    Hello, there is a tiny issue. You website is not accessible. Yours, Karim

    0
  • Rimka•600
    @karimfilaliPosted over 2 years ago

    Hello, congratulations for finishing your first FrontEndMentor challenge ! Your card is very great, the sizes fit good with the expected design. However, you have some accessibility issues. To fix them, you must have a <main> tag in your body. The .container div must be in the main tag or you can add role="main" to .container . Also, every website must have a h1 for accessibility reasons. Your h2 should be a h1. But use <h1> tag only once in main heading element.

    Very great job though !

    Marked as helpful
    0
  • Rimka•600
    @karimfilaliPosted over 2 years ago

    Hello, congratulations for finishing your first FrontEndMentor challenge ! Your card is very great, the sizes fit good with the expected design and the hover effects works well. However, you have an accessibility issue. To fix it, your website must have a h1 for accessibility reasons. Your h2 should be a h1. But use <h1> tag only once in main heading element.

    Very great job though !

    0
  • Rimka•600
    @karimfilaliPosted over 2 years ago

    Hello, congratulations for finishing your first FrontEndMentor challenge ! Your card is very great, the sizes fit good with the expected design. However, you have some accessibility issues. To fix them, you must have a <main> tag in your body. The .card div must be in the main tag or your can add role="main" to the .card. Also, you can add max-width to the .card or add padding to the body so the edges of the card don't touch the screen

    Very great job though !

    0
  • Rimka•600
    @karimfilaliPosted over 2 years ago

    Hello, your card is very great, you don't have accessibility issues which is very good. The background-image is missing. You can add a background-image with position: absolute and z-index: -1. Or you can write : body : { background: url("ImageURL") contain no-repeat Well done !

    1
  • sushil540•40
    @sushil540Submitted over 2 years ago

    Hey everyone! I've just completed the NFT-preview-card code challenge. Any feedback and suggestions on how i can improve are would be helpful.

    NFT-preview-card

    3
    Rimka•600
    @karimfilaliPosted over 2 years ago

    Hello, congratulations for finishing your second FrontEndMentor challenge ! Your card is very great. The card is a little small but the sizes fit good with the expected design. However, you have an accessibility issue. To fix it, your website must have a h1 for accessibility reasons. Your p.t1 should be a h1. But use <h1> tag only once in main heading element.

    Very great job though !

    Marked as helpful
    0
  • Rimka•600
    @karimfilaliPosted over 2 years ago

    Hello, congratulations for finishing your first FrontEndMentor challenge ! Your card is very great, the sizes fit good with the expected design. However, you have some accessibility issues. To fix them, you must have a <main> tag in your body. The .main_div and the .author div must be in the main tag. Also, every website must have a h1 for accessibility reasons. Your h2 should be a h1. But use <h1> tag only once in main heading element. Finally, adding the font-family doesn't work for every text. You should better write : * { font-family : 'Outfit' }

    Very great job though !

    Marked as helpful
    1
  • KENDRA•50
    @KNWardSubmitted over 2 years ago
    What are you most proud of, and what would you do differently next time?

    I completed this challenge a long time ago, I don't remember.

    What challenges did you encounter, and how did you overcome them?

    I completed this challenge a long time ago, I don't remember.

    What specific areas of your project would you like help with?

    I completed this challenge a long time ago, I don't remember.

    Mobile-first solution using flexbox- QR Code Component

    1
    Rimka•600
    @karimfilaliPosted over 2 years ago

    Hello, congratulations for finishing your first FrontEndMentor challenge ! Your card is very great, the sizes fit good with the expected design. However, you have some accessibility issues. To fix them, you must have a <main> tag in your body. The .container div and the .attribution div must be int the main tag Also, every website must have a h1 for accessibility reasons. Your h2 should be a h1. But use <h1> tag only once in main heading element.

    Very great job though !

    Marked as helpful
    0
  • Rimka•600
    @karimfilaliPosted over 2 years ago

    Hello, congratulations for finishing your first FrontEndMentor challenge ! Your card is very great, the sizes fit good with the expected design. However, you have some accessibility issues. To fix them, you must have a main tag in your body. You can add a <main> tag to your body or add role = "main" to your .content div. Also, every website must have a h1 for accessibility reasons. Your h3 should be a h1. Very great job though !

    Marked as helpful
    1
  • Rimka•600
    @karimfilaliPosted over 2 years ago

    Hello, your card looks very great. The sizes fit really good with the recommanded design. However, you have some accessibility issues. To fix them you must add a <main> tag to your body or add role = "main" to the #qr-code-display div. Besides, every image of a website must contain a alt attribute. In case of the image does not exist or is not found, an alternative text will be written. You should add alt attribute to your qr-code image. Very good job though !

    0
  • Zglob•250
    @ZglobiulViuSubmitted over 2 years ago

    Do colors look different on every device? on my phone it looks different 🤡

    CARD-COMPONENT

    1
    Rimka•600
    @karimfilaliPosted over 2 years ago

    Hello, your card looks very great. The colors correspond to the recommended design. You have a tiny accessibility issue. The .desktop-patter and .mobile-patter images must be in the main tag. If you prefer, you can add them to the body with background : url("imageURL") contain no-repeat. Great job though !

    Marked as helpful
    1