React JS

Community feedback

• 

  Zineb Boutaa•750

  @zineb-BouPosted almost 3 years ago

  Hi there, here are some suggestions that may help you to improve your code even further.

  1- The card doesn't fit all the screen sizes, 590px <scren-size<700px the pattern divider gets overflow the card, your solution should be responsive.

  2-The get request needs to be done when clicking on the dice button, you can be done using only the effect hook.

  3- For accessibility purposes, you need to use the right HTML semantic element, so instead of using <dev> for the dice button use <button>. you also need to hide any images from the screen readers that have a decoration purpose.

  Good luck 😃

  1
• 

  Rimka•600

  @karimfilaliPosted almost 3 years ago

  Hello! Good work with this project. Looking at your solution, I would like to suggest that you add the second parameter to the fetch method in your App.js file to enable it fetch new advice every time a user clicks the dice button. You could add something like this: fetch(url, { cache: "no-cache", }); Hope this was helpful..

  1
• 

  Dev Rathore•2,600

  @GitHub-dev12345Posted almost 3 years ago

  You want to reduce your accessibility, to change this code :

  <div id="root"> to <main> (Used main tag for main design components);

  I hope you find this helpful

  0