HTML, CSS

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Shivraj, great job!

  Try to use flexbox to App class for center the element and remove all margin from dashboard class. Read here -> flex guide

  Also set heigth of body to 100vh because Flexbox aligns to the size of the parent container.

  In the end, add main tag and wrap the content inside it to improve Accessibility.

  Hope this help and happy coding ;)

  Marked as helpful

  0
• 

  Rimka•600

  @karimfilaliPosted over 2 years ago

  Hello, congratulations for finishing your first FrontEndMentor challenge ! Your card is very great, the sizes fit good with the expected design. However, you have some accessibility issues. To fix them, you must have a <main> tag in your body. The .container div must be in the main tag or you can add role="main" to .container . Also, every website must have a h1 for accessibility reasons. Your h2 should be a h1. But use <h1> tag only once in main heading element.

  Very great job though !

  Marked as helpful

  0