This was good challenge. i really like new design files, they are good structured, and comfortable for work
grgrnkoo
@grgrnkooAll comments
- @SabaMarghania1Submitted 5 months agoWhat are you most proud of, and what would you do differently next time?@grgrnkooPosted 4 months ago
Good solution! Glad to see you completed it!
The only thing that doesn't fit the task is that you don't have focus states on your input. It should have a lime border and a lime background on the input decorations.
Also, your input decorations are moving up on error states, add a bit of padding and
overlay: hidden
. Aaaaaand also if you want to complete it perfectly, add acursor pointer
on each interactive element:)Other than that, your work is perfect. Happy coding!
Marked as helpful0 - @amjadsh97Submitted 4 months agoWhat are you most proud of, and what would you do differently next time?
I learned how to handle product counts, unique product lists, and total price calculations in a shopping cart context using JavaScript. Here's a breakdown of what I implemented:
// Calculate the count of each product const productCounts = selectedProducts.reduce((acc, product) => { acc[product.name] = (acc[product.name] || 0) + 1; return acc; }, {} as Record); // Create a list of unique products with their counts const uniqueProducts = selectedProducts.reduce((acc: Product[], product) => { if (!acc.find(p => p.name === product.name)) { acc.push(product); } return acc; }, []); // Calculate total price const totalPrice = selectedProducts.reduce((acc, product) => acc + product.price, 0); ### What specific areas of your project would you like help with? I want feedback on state management
@grgrnkooPosted 4 months agoGood job! All nuances are perfectly worked out! Can not find anything that could be upgraded!
Marked as helpful0 - @AymmaannSubmitted 5 months ago@grgrnkooPosted 5 months ago
Nice job, but looks like you lost the closing
"
on each quote:)0 - @NaythankikSubmitted 5 months ago@grgrnkooPosted 5 months ago
Great solution! I took your fetching method and tried to apply it to my solution! Thanks
But I think you forgot to add interactivity for a dice button. You can try
dice.addEventListener('click', randomAdvice)
after initializing a dice value withgetElementById
1 - @Caelus111Submitted 11 months ago
All advices are appreciated!!
@grgrnkooPosted 5 months agoYour solution is amazing! I just finised mine, opened your code and realised that I totally forgot to remove error class while clicking a Reset button
Nice attention to the details. Good job!
0 - @Hamidqasemi90Submitted 6 months agoWhat are you most proud of, and what would you do differently next time?
sorry the picture is not working.
@grgrnkooPosted 6 months agoHi! You can try adding a dot before image’s path. Like
.images/image-qr-code.png
instead ofimages/image-qr-code.png
this should work
0 - @jjuniorbrasilSubmitted 6 months agoWhat are you most proud of, and what would you do differently next time?
Proud of doing it using the 'state' logic.
What challenges did you encounter, and how did you overcome them?No specific challenges.
What specific areas of your project would you like help with?None for now.
@grgrnkooPosted 6 months agoDamn! Your project looks solid. Just finished the same project and your solution with states is the thing that I want to overthink right now. Happy coding!
UPD: Checked the media queries. You should spend a bit more time to apply all screen sizes. Text doesn't fit the cards size in the width range of 1030 - 770 px
Marked as helpful0 - @willengarciaSubmitted 6 months agoWhat are you most proud of, and what would you do differently next time?
entregaria o mais rápido possível, e estudaria regex.
What challenges did you encounter, and how did you overcome them?A utilização de Regex, e o uso de localStorage
What specific areas of your project would you like help with?nenhuma
- @svo15Submitted 6 months agoWhat are you most proud of, and what would you do differently next time?
im proud about not give upping and second time i will better study basics
What challenges did you encounter, and how did you overcome them?mobile version text problems in where was name im just change width to min-width
What specific areas of your project would you like help with?object overflow
@grgrnkooPosted 6 months agoNice solution! You probably should take a bit more time on adjusting styles to reach a look-a-like design from the challenge. But technically your JS code is amazing and much simpler than mine! Good job!
0 - @grgrnkooSubmitted 9 months ago
It took me less than an hour, I'm glad that I made this progress. First QR took about 2-3. One step closer to completing all HTML/CSS challenges
Why do Button colors and h1 margin not apply in the solution card?! First time facing such an issue. GitHub Pages shows it right
Appreciate your reviews!
@grgrnkooPosted 9 months agoWhy do Button colors and h1 margin not apply in the solution card?! First time facing such an issue
0 - @grgrnkooSubmitted 9 months ago
It was really hard to apply that box position to work dynamically, not only in tasks breakpoints of 1440px and 375px.
I really want to get review from more experienced coders Do I did it right? Or is it any common simple solution on how to attach absolute object to a point in a flow. Googling didn't help. Mine works just on media queries in a breakpoints
Any other task compared to this absolute object was quite simple and understandable
@grgrnkooPosted 9 months agoAfter reviewing other solutions I understood only one thing. It doesn't have to be full-flexible. I did a ton of extra job applying this. But it still works, so my job was not pointless
0