Design comparison
Solution retrospective
It took me less than an hour, I'm glad that I made this progress. First QR took about 2-3. One step closer to completing all HTML/CSS challenges
Why do Button colors and h1 margin not apply in the solution card?! First time facing such an issue. GitHub Pages shows it right
Appreciate your reviews!
Community feedback
- @danielmrz-devPosted 9 months ago
Hello @grgrnkoo!
Your solution looks great!
I have a suggestion for improvement:
- Use
<main>
to wrap the main content instead of<div>
.
š Think of
<div>
and<span>
in HTML like plain boxes or placeholders. They're handy for holding content, but they don't tell us anything about what's inside or what it's meant for on the webpage.This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, great job!
0 - Use
- @zaid333saPosted 9 months ago
Hello, I would like to suggest you changing the color and border of the button when hover like this: old button { color: hsl(179, 100%, 13%); transition: color 0.5s; } button:hover { color: hsl(0, 0%, 95%); }
updated
button:hover { color: hsl(0, 0%, 95%); background-color: transparent; border: 1px solid white; }
0 - @grgrnkooPosted 9 months ago
Why do Button colors and h1 margin not apply in the solution card?! First time facing such an issue
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord