@Adrian-pySubmitted over 2 years ago
Any feedback on the code is appreciated, especially on the quality of the react code and how to make the code cleaner. Thank you!
Teresczuk Gabriel
@gabrielteresczukAll comments
- @gabrielteresczukPosted over 2 years ago
Hello ! 😊 Its a beautiful project, viewing it i learned about, motion div that i wont know already. I find a little visual problem in 375px resolution, the win/lose div, si not centered, is like flex-ended, no more to add. Great work, and keep up !
Hola! 😊 Es un hermoso proyecto, viendolo aprendi acerca de "motion div", que no conocia hasta ahora. Encontre un pequeño problema visual en 375px, que el div de win/lose, no esta centrado, sino que parece que se esta marginado con flex-end, nada mas que agregar. Buen trabajo y sigue asi!
Marked as helpful1 - @loicmaesSubmitted over 2 years ago
What do you think, should I make the mobile version?
@gabrielteresczukPosted over 2 years agoA pretty nice project, the shadows, the animation i really loved. The only little thing is the preview site need to be the Live Site Url, for the FrontEndMentor report. Everything else is excellent. it is clarified in the project that it is only the desktop version. Good work and keep up 💪
Hermoso proyecto, las sombras, las animaciones realmente me encanto. La unica cosita es que el sitio de preview, tiene que ser el "live site url", para que FrontEndMentor, te genere el reporte. Todo lo demas esta excelente, esta claro, que el proyecto es solo la version de escritorio. Buen trabajo y segui asi! 💪
0 - @CristopherVASubmitted over 2 years ago@gabrielteresczukPosted over 2 years ago
Hello! 🙋♂️ Great job man, i really like the final animation at winning 🎊. I can see a little problem, when you pick a token for FIRST time, it dosn´t show, but the second time it show it. Explame, you pick rock the first time, dont show, the second time, its show, like a cache thing. And i cant saw the rules, you can do it easy with "modal windows". Good work, keep working ! 💪
Hola! 🙋♂️ Gran trabajo, realmente me gusto mucho la animacion final 🎊. Pude ver un pequeño problema, cuando elegis un token, por PRIMERA vez, no lo muestra, pero la segunda vez si. Por ejemplo, si elijo roca, la primera vez, no lo muestra, pero la segunda vez, si, parace algo tipo cache. Y pude ver que no muestra las reglas, es facil de hacer con "Ventanas modales". Buen trabajo, sigue asi! 💪
Marked as helpful0 - @warrenleeSubmitted over 2 years ago
Another very interesting challenge and fully enjoyed coding this. I used Vue 3 and Pinia to state manage the game like keeping track of the score, the counter the player chose and managing which screen should be shown.
I do prefer to use Vue when there's transition and animation involved between components as I think Vue handles this well. The layout is fully responsive which turned out quite well.
@gabrielteresczukPosted over 2 years agoNice desing man!. I really loved the animation between the interactions. I saw just a little visual problem, with the backgrand color, when you put the height: 100vh, the background breaks any content after 100vh, and the backgraund repeat the gradient. -tested in 375px after win/lose the hand.
Muy buen diseño!, me encantaron las animaciones entre las interacciones. Solo encontre un pequeño problema visual, con el background color, cuando pones height:100vh, the fondo se rompe al pasar ese 100vh y repite el mismo radial gradient. -tested in 375px despues de ganar/perder la mano.
1
