@WilliamValetteSubmitted about 2 months ago
Chijioke Nwabasili
@devceejayAll comments
- @devceejayPosted about 2 months ago
Hi, @William.. I think it's best you do the project challenge yourself, that way you learn.. it should be progress before perfection.
It's obvious, your work was a copy and paste code.
0 - @HaseebaAlhaddiSubmitted about 2 months ago@devceejayPosted about 2 months ago
Hello! @haseebaalhaddi Great job on the project! but here's my observation, I noticed that you used the h1 tag throughout the entire document. Typically, the h1 tag should be reserved for the main heading of the page, as it helps define the primary topic. For better structure, consider using h2 for main sections. This will improve the document's hierarchy, making it easier for both users and search engines to understand the content. It will also enhance accessibility and SEO.
Hope you find this feedback helpful. Good job overall!
Happy Coding!
0 - @nakelcodeSubmitted 2 months agoWhat are you most proud of, and what would you do differently next time?
I'm really proud and glad that I was able to apply Grid in this project. The joy in me after finishing this project can't shake right now
What challenges did you encounter, and how did you overcome them?The challenge I faced was with Grid and I had to go back and learn about Grid to be able to do this project well
What specific areas of your project would you like help with?I don't know if I have any problems with this project but I will be glad if you can check and give me response on what mistakes I made in this project
@devceejayPosted 2 months agoHello!👋 @@nakelcode good job on completing the challenge but here are my observations while going through your code, I noticed your non usage of Semantic HTML to structure your code well.
Secondly, the order in which you used your headings hierarchy (h3, h2) is wrong and not a good code practice.
Typically, the h1 tag should be reserved for the main heading of the page, as it helps define the primary topic. For better structure, consider using h2 for main sections. This will improve the document's hierarchy, making it easier for both users and search engines to understand the content. It will also enhance accessibility and SEO.
Another thing where you used the section tag is inappropriate whereas the section tag should contain all content for the card.
I hope you find this feedback helpful and nice job overall!
0 - @uzainmalik123Submitted 2 months agoWhat are you most proud of, and what would you do differently next time?
No difficulties. I have done things differently i would do things more differently when i find out more ways to make the code better.
What challenges did you encounter, and how did you overcome them?Didn't encounter any problems.
What specific areas of your project would you like help with?Any feedback will be appreciated.
@devceejayPosted 2 months agoHello! @uzainmalik123 Great job on the project! but here's my observation, I noticed that you used the h1 tag throughout the entire document. Typically, the h1 tag should be reserved for the main heading of the page, as it helps define the primary topic. For better structure, consider using h2 for main sections. This will improve the document's hierarchy, making it easier for both users and search engines to understand the content. It will also enhance accessibility and SEO.
Hope you find this feedback helpful. Good job overall!
Happy Coding!
Marked as helpful1 - @ChihaAdamSubmitted 3 months ago@devceejayPosted 3 months ago
Hello! @ChihaAdam great job on completing the challenge. But here's my observation while going through your code, the hierarchy in which you used your headings in this order (h4,h1,h3,h2) is wrong. Ensure you always use accurate headings hierarchy in your projects/webpages.
Also, always ensure to use clean and semantic HTML to best structure your code for easy readability, accessibility and SEO (Search Engine Optimization)
I hope you find this feedback helpful.
Good job overall, Happy Coding!
Marked as helpful0 - @kalebalmeidaSubmitted 3 months ago@devceejayPosted 3 months ago
Hello! @kalebalmeida, good job on completing the project challenge. well done! Just a tip I want to give to you: typically your project/web page should have a heading <h1> but looking at your project, there was none. So, I suggest you replace the <p> you started your project with <h1> to give it a more meaningful structure for better understanding.
I hope you find this tip helpful.
The rest is spot on👌
Good job overall!
Marked as helpful0 - @progfishSubmitted 3 months agoWhat are you most proud of, and what would you do differently next time?
I am most proud of the small amount of time it took me to complete the challenge.
What challenges did you encounter, and how did you overcome them?One challenge I encountered was getting the linear gradient to match pretty closely with the solution. I overcame it through trial and error, but it taught me more about using that CSS function to create an attractive design.
What specific areas of your project would you like help with?I would appreciate any feedback you have on the styles and HTML structure I used. I still struggle with responsiveness, but I think I am getting the hang of it.
@devceejayPosted 3 months agoHello! @progfish Great job on completing the challenge but here's a tip I want to give to you based on my observation on your project. I noticed that the circle is not in perfect shape. To fix it, give it a padding and a margin: auto;
I hope you find this feedback helpful.
Happy Coding! And good job overall.
0 - @MotunzSubmitted 3 months agoWhat are you most proud of, and what would you do differently next time?
My most proud moment while doing this project was been able to use media query. This project is my first detailed project that allowed me explored media query. It's not perfect yet but with consistent practice and practical use it will be better.
What challenges did you encounter, and how did you overcome them?My first challenge during this project was using different image for both desktop and mobile view but I was able to overcome this by learning more about Image for both HTML and CSS on W3School as well as ChatGPT.
What specific areas of your project would you like help with?I will like help with how to design project like this or any other one in future with mobile first then desktop.
@devceejayPosted 3 months agoHi, @Motunz Good work on your project! However, I noticed you used id attributes throughout the entire project for styling which should be reserved for unique elements. It's better to use class for styling and reusable behaviors, as id should only be used for a single, unique element on the page. Additionally, consider using semantic HTML elements like <main>, <article>, <section>, instead of generic <div> tags. This will improve your site's accessibility, SEO, and readability, making it easier for both developers and users to navigate your content.
Marked as helpful0 - @salehjosephSubmitted 3 months ago@devceejayPosted 3 months ago
Hello! @saleh-joseph good job on completing the project challenge but here are my observations.. Firstly, going through your code, I noticed your non usage of Semantic HTML elements such as (main, section, etc) which is not cool for good code practice. Using divs is quite okay but using Semantic HTML best structures your code well for easy readability and understanding of which it is also great for SEO (Search Engine Optimization) and accessibility. Don't always neglect using Semantic HTML to properly define the structure of your web pages/projects.
Secondly, on mobile viewing, your project looks awkward. You should work on its Responsiveness using media queries. And to fix this, you set both results and summary section, giving them a width of 100% so that it adjusts perfectly on mobile screen
I hope you find this feedback helpful.
Happy Coding!
1 - @AbigirlMuchineripiSubmitted 3 months agoWhat are you most proud of, and what would you do differently next time?
I'm proud of completing this card component project because it showcases my ability to write clean, organized code, solve problems, and design user-friendly interfaces. Each step taught me something new and brought me closer to mastering front-end development!
What challenges did you encounter, and how did you overcome them?At first I used border for the desktop buttons. They were not working well with the hover effect, then i changed to using the border element.
What specific areas of your project would you like help with?Your feedback is appreciated. I would like to hear what you think about the project. Corrections are welcome.
@devceejayPosted 3 months agoHi! @AbigirlMuchineripi Great job on the project! but here's my observation, I noticed that you used the h1 tag throughout the entire document. Typically, the h1 tag should be reserved for the main heading of the page, as it helps define the primary topic. For better structure, consider using h2 for main sections. This will improve the document's hierarchy, making it easier for both users and search engines to understand the content. It will also enhance accessibility and SEO.
Hope you find this feedback helpful.
Happy Coding!
1 - @Henrietta-DareSubmitted 3 months ago@devceejayPosted 3 months ago
Hi! @Henrietta-Dare nice job on completing the challenge but here's my observation while going through your code, the hierarchy in which you used your headings in this order 👉(h2, h1) is wrong and not a good code practice. Always ensure you use the accurate hierarchy for headings in your web page/projects.
Where you made use of h2, you could use a <span> tag in place of it.
Hope, you find this feedback helpful.
Good job overall!
Happy Coding!
0 - @Henrietta-DareSubmitted 3 months ago@devceejayPosted 3 months ago
Hi! @Henrietta-Dare good job on completing the challenge but the only tip I have to give, is you working on the font size of the heading of your project so it exactly matches the design.
The rest is spot on 👌 good job overall!
Happy Coding!
0 - @M1roelSubmitted 3 months ago@devceejayPosted 3 months ago
Hello! @M1roel good job on completing the project but here's my observation while going through your code, I see you didn't make use of Semantic HTML to structure your code. Using divs is quite okay but using Semantic HTML best structures your code well for easy readability and understanding of which it is also great for SEO (Search Engine Optimization) and accessibility. Don't always neglect using Semantic HTML to properly define the structure of your web pages/projects.
Also, on mobile viewing, your project is not well placed (centered) on the screens viewport.. try and work on its Responsiveness.
I hope you find this feedback helpful.
Happy Coding!
0 - @Omar25876Submitted 3 months ago@devceejayPosted 3 months ago
Hello! @omar25876 good job on completing the project but I have an observation.. on mobile viewing I noticed your card is not centered.. you should work on its Responsiveness.
Also, while going through your code, I see you didn't make use of Semantic HTML to structure your code. Using divs is quite okay but using Semantic HTML best structures your code well for easy readability and understanding of which it is also great for SEO (Search Engine Optimization) and accessibility. Don't always neglect using Semantic HTML to properly define the structure of your web pages/projects.
I hope you find this feedback helpful.
Happy Coding!
Marked as helpful0 - @Enisco29Submitted 3 months ago@devceejayPosted 3 months ago
Hello! @enisco29 good job on completing the challenge but here's my observation in your code, I noticed your non usage of Semantic HTML elements such as (main, header, section etc) which is not cool for good code practice. Using divs is quite okay but using Semantic HTML best structures your code well for easy readability and understanding of which it is also great for SEO (Search Engine Optimization) and accessibility. Don't always neglect using Semantic HTML to properly define the structure of your web pages/projects.
Another thing, you didn't entirely follow the design requirements that was given for the project. Ensure to always do that for your next project(s)
Also, always give a descriptive and concise meaning to your alt text for images.
I hope you find this feedback helpful.
Happy Coding!
Marked as helpful0 - @khatri2002Submitted 3 months ago@devceejayPosted 3 months ago
Hello! @khatri2002, Great job on the project! but here's my observation, I noticed that you used the h1 tag throughout the entire document. Typically, the h1 tag should be reserved for the main heading of the page, as it helps define the primary topic. For better structure, consider using h2 for main sections. This will improve the document's hierarchy, making it easier for both users and search engines to understand the content. It will also enhance accessibility and SEO.
Also, fix your alt text for images, you wrote "icon sedans" for all of them.
Moreso, I noticed you used the <button> element styled as a button for a link. It's generally better to use the <a> (anchor) tag for navigation or linking purposes, as it’s semantically correct for this role and improves accessibility. The <button> element is typically meant for actions like submitting forms or triggering events, not for navigation. Consider replacing the <button> with an anchor tag, and keep the button styles to maintain the design you’ve applied. This will improve both the accessibility and semantics of your code.
To fix this: Write <a href="#">Learn More</a>
To keep the button styles, do this: <a href="#" class="button-link">Learn More</a> and style using the class name
Hope this helps, and great work overall!
Marked as helpful0 - @ObikaviolaSubmitted 12 months agoWhat are you most proud of, and what would you do differently next time?
I am happy I got to complete this challenge with little challenges. As for next time, I intend on first making an outline of what I want to achieve and coordinated steps with which I intend on achieving it.
What challenges did you encounter, and how did you overcome them?No challenges for this particular project
What specific areas of your project would you like help with?I would need help with understanding accessibility. An article or any resource would be appreciated.
@devceejayPosted 3 months agoHi @obikaviola, Great job on the project! but here's my observation, I noticed that you used the h1 tag throughout the entire document. Typically, the h1 tag should be reserved for the main heading of the page, as it helps define the primary topic. For better structure, consider using h2 for main sections. This will improve the document's hierarchy, making it easier for both users and search engines to understand the content. It will also enhance accessibility and SEO.
Also, I noticed you used the <button> element styled as a button for a link. It's generally better to use the <a> (anchor) tag for navigation or linking purposes, as it’s semantically correct for this role and improves accessibility. The <button> element is typically meant for actions like submitting forms or triggering events, not for navigation. Consider replacing the <button> with an anchor tag, and keep the button styles to maintain the design you’ve applied. This will improve both the accessibility and semantics of your code.
To fix this: Write <a href="#">Learn More</a>
To keep the button styles, do this: <a href="#" class="button-link">Learn More</a> and style using the class name
Hope this helps, and great work overall!
1 - @GuillermoBlancarteSubmitted 3 months ago@devceejayPosted 3 months ago
Hello! @guillermoblancate, Great job on the project! but here's my observation, I noticed that you used the h1 tag throughout the entire document. Typically, the h1 tag should be reserved for the main heading of the page, as it helps define the primary topic. For better structure, consider using h2 for main sections. This will improve the document's hierarchy, making it easier for both users and search engines to understand the content. It will also enhance accessibility and SEO.
Also, use a descriptive and concise alt text for your image. Using alt="image" isn't descriptive enough. You could write alt="icon representing a sedan car"
Again, I noticed you used the <button> element styled as a button for a link. It's generally better to use the <a> (anchor) tag for navigation or linking purposes, as it’s semantically correct for this role and improves accessibility. The <button> element is typically meant for actions like submitting forms or triggering events, not for navigation. Consider replacing the <button> with an anchor tag, and keep the button styles to maintain the design you’ve applied. This will improve both the accessibility and semantics of your code.
To fix this: Write <a href="#">Learn More</a>
To keep the button styles, do this: <a href="#" class="button-link">Learn More</a> and style using the class name
Hope this helps, and great work overall!
0
