HTML and CSS solution

Community feedback

• 

  P

  Trần Thành Danh•1,500

  @TranDanh1122Posted 3 months ago

  Thật good, bút maybe you can improve something:

  1. No need center card with margin 16px, if you need center x, use margin 0 auto, if need x and y, just use flex box for parent.
  2. When you import font, try import only which font weight you need, that will cause performance issue if you import like now in real life project

  Marked as helpful

  0

  ---

  

  Omar Mohamed Ibrahim•10

  @Omar25876Posted 3 months ago

  @TranDanh1122 okay thanks 🙏

  0
• 

  Chijioke Nwabasili•290

  @devceejayPosted 3 months ago

  Hello! @omar25876 good job on completing the project but I have an observation.. on mobile viewing I noticed your card is not centered.. you should work on its Responsiveness.

  Also, while going through your code, I see you didn't make use of Semantic HTML to structure your code. Using divs is quite okay but using Semantic HTML best structures your code well for easy readability and understanding of which it is also great for SEO (Search Engine Optimization) and accessibility. Don't always neglect using Semantic HTML to properly define the structure of your web pages/projects.

  I hope you find this feedback helpful.

  Happy Coding!

  Marked as helpful

  0

  ---

  

  Omar Mohamed Ibrahim•10

  @Omar25876Posted 3 months ago

  @devceejay thanks for your notes will check it 😄

  0
• 

  MolinaEf•330

  @MolinaEfPosted 3 months ago

  Seems like u wanted to do something different so I cant really comment I'd still add some margin-top to ur subtext so it looks better

  Marked as helpful

  0

  ---

  

  Omar Mohamed Ibrahim•10

  @Omar25876Posted 3 months ago

  @MolinaEf thanks I will check it 😃

  0
• 

  Peter Pfautsch•20

  @M1roelPosted 3 months ago

  Looks great.

  0

  ---

  

  Omar Mohamed Ibrahim•10

  @Omar25876Posted 3 months ago

  @M1roel Thank you 🙏

  0