@NathanGeovaneSubmitted 26 days ago
P
Daniel Tving
@dantviAll comments
- @dantviPosted 26 days ago
Great work on your newsletter sign-up form! I love the clean and professional design; it’s user-friendly and visually appealing. The success message after signing up is clear and provides excellent feedback to the user, which enhances the overall experience.
Your code is well-organized and generally well-structured! Here are some suggestions for improvement:
• Email Validation Enhancement: Right now, if the email is invalid, the @ symbol is replaced with # in the input value. This can be confusing to users, as they might not understand why the email is being changed. Instead of modifying the input, consider only showing the error message without altering the user's input.
• Empty Input Check: Currently, the empty input check happens after the general validation. It's a good idea to check if the input is empty before checking if it’s a valid email.
• Improving User Experience with Focus: Set the focus back on the input field if there's an error, helping the user fix it quickly.
With these changes, your code should be cleaner, more user-friendly, and easier to follow. Great job on this project so far! Let me know if you have further questions.
Marked as helpful0 - @mudasirNadeemSubmitted about 2 months agoWhat challenges did you encounter, and how did you overcome them?
I encountered challenges with handling complex user interactions and ensuring the DOM updated in real-time without lag. To overcome this, I used event listeners efficiently and organized my JavaScript code to manage multiple elements. Debugging tools also helped identify issues quickly and fix them.
What specific areas of your project would you like help with?I would appreciate help with optimizing my JavaScript code for better performance, particularly when handling multiple event listeners. Additionally, I’d like feedback on how to refactor my code to make it more modular and maintainable for future updates.
@dantviPosted about 2 months agoGreat job in completing the challenge! I can see that you have used Bootstrap as a tool to build up your webpage. It is good that you are working with frameworks to improve the time it takes to code front end applications. Your webpage is fully responsive and does a good job in handling different screen sizes.
However, the design of your card is quite different from the design file. On desktop the following improvements can be made:
- Instead of having the main image take up fifty percent of the card try using like 1/3 instead.
- Check the max width of the card element so it doesn’t become so large on desktop screens.
- The colour of your fonts is not entirely correct, try using a more greyish blue.
Kind regards Daniel
Marked as helpful0 - @praistylesSubmitted 2 months ago@dantviPosted 2 months ago
Hello Praistyles, First of all, let me congratulate you on finishing the challenge. This was not an easy challenge and you have done a good job. Your webpage looks quite good but there are a couple of things that you can do to improve the layout.
Instead of using the same layout for mobile, tablet and desktop you can improve the solution to use the different images that are designed for the respective layout. Check the starter files and you will se different folders for the correct layout.
Ex. For the desktop version the hero images are composed of two different images that should be placed to the left and right, with the text and button content in the middle. Since you are using one hero image it becomes really large when is gets displayed on a large desktop screen.
The buttons also grow to a very large size when the user is on a desktop. Try using a max with to limit the size.
The four images in the middle looks really good.
The footer should be composed of three columns of equal size for the header, text and button. One way of doing this is to use CSS Grid with the “grid-template-columns” properties.
I hope this feedback helps.
Kind Regards Daniel
Marked as helpful0 - @Pan1402Submitted 2 months ago@dantviPosted 2 months ago
Excellent job on completing the challenge! Your webpage looks quite good! There are two things that you can improve on. The first one is that Daniels user image should have a purple boarder instead of blue. And the second is that your card size is quite large compared to the original design. Otherwise well done!
Marked as helpful0 - @faaazySubmitted 3 months ago@dantviPosted 3 months ago
Your webpage looks really good! But I think that you have submitted to the wrong challenge. This is the “Four card feature section”.
0 - @dzerdzulSubmitted 3 months ago
- @SpartanFrancoSubmitted 3 months ago@dantviPosted 3 months ago
Good work on your solution! It is really similar to the design. One thing that you can improve on to get it to look more like the design is to increase the top margin on the card. You have a margin-top that is half the size compared to the design file. Otherwise, great work!
Marked as helpful0 - @patriciarrsSubmitted 3 months agoWhat are you most proud of, and what would you do differently next time?
I used some of the same concepts as in previous solutions.
What challenges did you encounter, and how did you overcome them?Nothing in particular.
What specific areas of your project would you like help with?Any feedback is welcome! :)
@dantviPosted 3 months agoGreat work! Your project looks really good and is a complete replica of the design file 😊
1 - @Manpreet-01Submitted 4 months ago@dantviPosted 3 months ago
Great work in completing the challenge! Your project looks really good and its quite similar to the design file. I would make the card a bit bigger because it’s a bit small compared to the design.
0 - @kursatdemirdelenSubmitted 3 months agoWhat are you most proud of, and what would you do differently next time?
Start this project the most proud for me
What challenges did you encounter, and how did you overcome them?using ai and documents
What specific areas of your project would you like help with?I may request improvements in the css section
@dantviPosted 3 months agoYour project looks great and it is quite similar to the design file. One thing that you can check is the height of the card component. It’s not really the same as the design file. But it’s a very small improvement that doesn’t make much of a difference.
0
