Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code component using HTML&CSS

@kursatdemirdelen

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

Start this project the most proud for me

What challenges did you encounter, and how did you overcome them?

using ai and documents

What specific areas of your project would you like help with?

I may request improvements in the css section

Community feedback

Alex 3,130

@Alex-Archer-I

Posted

Hey, congrats with your first challenge here =)

A couple of tips =)

  • Try not hardcode width and height of the container (I mean your box element). Instead of width better to use max-width to allow it adjust to the small screens. As for height - usually you shouldn't specify it at all. It's better if the content will define the height of the container. If you still need to fit the template - try to regulate height with paddings. It is in case if the content would change in the future and will be lager than height of your element.
  • Learn about rem units and use them at least for font-size. It's a relative units which value depends on the font setting of the browser.
  • Add main element to your page - it is important semantic tag which should be on the almost every page.

And I really recommend you to keep html and styles in separate files =)

Overall, your work is very neat, keep doing =)

0
P
Daniel 150

@dantvi

Posted

Your project looks great and it is quite similar to the design file. One thing that you can check is the height of the card component. It’s not really the same as the design file. But it’s a very small improvement that doesn’t make much of a difference.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord