QR code component using HTML&CSS

Community feedback

• 

  Alex•3,130

  @Alex-Archer-IPosted 4 months ago

  Hey, congrats with your first challenge here =)

  A couple of tips =)

  • Try not hardcode width and height of the container (I mean your box element). Instead of width better to use max-width to allow it adjust to the small screens. As for height - usually you shouldn't specify it at all. It's better if the content will define the height of the container. If you still need to fit the template - try to regulate height with paddings. It is in case if the content would change in the future and will be lager than height of your element.
  • Learn about rem units and use them at least for font-size. It's a relative units which value depends on the font setting of the browser.
  • Add main element to your page - it is important semantic tag which should be on the almost every page.

  And I really recommend you to keep html and styles in separate files =)

  Overall, your work is very neat, keep doing =)

  0
• 

  P

  Daniel Tving•230

  @dantviPosted 4 months ago

  Your project looks great and it is quite similar to the design file. One thing that you can check is the height of the card component. It’s not really the same as the design file. But it’s a very small improvement that doesn’t make much of a difference.

  0