Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

All comments

  • Ejiro Frances• 100

    @Ejiro-Frances

    Submitted

    What are you most proud of, and what would you do differently next time?

    I am most proud of the responsiveness of the page.

    What challenges did you encounter, and how did you overcome them?

    One of the challenges I encountered was the difference in the mobile view and desktop view images. I used the visibility:hidden property to switch the images between screen sizes.

    Another challenge was getting the image to fit within the image-container. I used em units and this worked.

    Another challenge I faced was adjusting the width of the desktop view.

    What specific areas of your project would you like help with?

    I would like feedback on best practices to achieve responsiveness on this component.

    Product Preview Card Component

    1

    brukmg• 120

    @brukmg

    Posted

    You’ve done a great job! I love that you used semantic HTML elements it’s awesome for both readability and SEO optimization.

    In the HTML section, the main element is used as a card, but there should be an additional div to act as the product container. For images, it's better to use a single img element and apply styling for various screen sizes as needed. Also, the 'Add to cart' element should be a button, not a div. Additionally, it would be more appropriate to wrap the container div with the class attribution in a footer element.

    For CSS, using 62% for the font size is too large, it’s recommended to use units like px for better control. The property display: flex on the body element is unnecessary. Instead, apply flex to the main element if you're centering the product card. To make the code more maintainable, consider using CSS variables for colors instead of hard coding them multiple times, which will make updates easier. Lastly, you've only implemented a media query for one screen size, but it would enhance responsiveness if you added queries for screen sizes like 768px, 1024px, 1140px, and more.

    Lastly, it's not best practice to place the CSS file in the assets folder, as it's a core part of your web app's program files and not just an asset.

    0
  • lazydroide• 110

    @lazydroide

    Submitted

    What are you most proud of, and what would you do differently next time?

    I've tried to code without assembling the figma file, and that was a mistake. So next time I will try to make sure I have a solid “design” before trying to move forward, because in the end everything has been more difficult than it should have been.

    What challenges did you encounter, and how did you overcome them?

    Trying to match the spacing to the preview was difficult and, in my opinion, overcomplicated the code

    Recipe page

    2

    brukmg• 120

    @brukmg

    Posted

    The code you've written has some really nice touches! You've applied a well-structured reset to ensure consistency across browsers, which is always a smart move. I love how you've used variables for colors, font sizes, and border-radius—it makes everything more manageable and scalable.The padding and margin adjustments throughout the layout are thoughtful, ensuring a clean and organized design. Plus, the way you've styled the lists for ingredients and instructions with custom markers adds a great touch of detail. Overall, it’s clear you’ve put a lot of thought into making the page both functional and visually appealing!

    For a couple of tweaks, consider switching to a <table> for the nutrition section to enhance accessibility and semantic structure. You can also remove the redundant a:not([class]) style since the .attribution a block already takes care of that. There are a few unnecessary selectors like picture, svg, video, canvas, input, button, textarea, select—those aren’t needed since these elements aren’t used in the HTML. There’s a minor conflict with the padding in .preparation-time and .preparation-list, and a small typo in .intructions and .intructions-list (it should be .instructions).

    Overall, it’s clear you've put a lot of thought into making the page both functional and visually appealing—just a few refinements will make it even better!

    Marked as helpful

    0
  • brukmg• 120

    @brukmg

    Posted

    The flex-direction property in main isn't really needed here since you're already centering everything nicely. And to make your code cleaner, try using CSS variables for your colors instead of hard-coding them multiple times—it will save you time and make things easier to update later. You're on the right track, and these small changes will only make your work even better! Keep it up!

    Marked as helpful

    0
  • brukmg• 120

    @brukmg

    Posted

    You’re already doing great by using semantic tags! Just a couple of tweaks, you don’t need to use role="main" and role="contentinfo" here, because main and footer are already semantic HTML5 tags that automatically serve those roles. Also, to make your code cleaner and easier to manage, it’s a good idea to store your colors in CSS variables. That way, you won’t have to repeat the same color values throughout your styles.

    Marked as helpful

    0
  • Garab• 20

    @Garab02

    Submitted

    What are you most proud of, and what would you do differently next time?

    Responsive part of the page.

    What challenges did you encounter, and how did you overcome them?

    Responsive.

    qr-code-componenet-main

    1

    brukmg• 120

    @brukmg

    Posted

    Using semantic HTML would improve the code quality, and it’s advisable to consider using CSS Flexbox or Grid for layout instead of relying on fixed padding, as this approach will enhance the responsiveness and adaptability of your design across different screen sizes. Additionally, rather than duplicating the styles for the .container class in both media queries, create a base style and modify only the properties that differ in the media queries. Finally, you can simplify padding by using shorthand notation for a cleaner and more efficient code structure.

    0