Skip to content
OverviewSolutions
4
Comments
56
Abdulla Bashiroglu
@bashiroglu

All comments

  • Abdulla Bashiroglu•520
    @bashirogluPosted about 4 years ago

    Hi, It looks nice, only thing I noticed the list borders in the professional card is not aligned with others, I am not saying this is bad but in the design file, it is aligned, so you can challenge yourself how to accomplish that design. Good luck

    0
  • Abdulla Bashiroglu•520
    @bashirogluPosted about 4 years ago

    Hi, It is always good to make main logo link and takes to index page, so you may improve by adding that. good luck

    0
  • Abdulla Bashiroglu•520
    @bashirogluPosted about 4 years ago

    Hi @hristoroque , it looks great, you may improve or make it like in design file by increasing padding x direction of main container. good luck

    0
  • Rahul Gupta•80
    @rahulxyzSubmitted about 4 years ago

    1. For active states of social media icons, I created 2 SVGs with different colors and switched them on hover. (a) Is there any way we can do it with CSS properties like "color" or anything? (b) Or any other better approach to it?

    2. In the articles section, for some size of the screen ( > 1024px i.e. for tablet view), one of the cards would increase in size as compared to others due to content length. For solving it, I have fixed the height for content and change it for different screen sizes. Is there any better approach to it?

    HTML, CSS(+SASS), JS

    3
    Abdulla Bashiroglu•520
    @bashirogluPosted about 4 years ago

    looks great, you can make it perfect by adding bg image in hero section. good job.

    0
  • Hiago Riba Guedes•30
    @HiaguedesSubmitted about 4 years ago

    It's my first challenge, i learned the basics four months ago but i really thing I did my best. Please feel free to give me some tips and what to study

    ip-address-tracker-master

    2
    Abdulla Bashiroglu•520
    @bashirogluPosted about 4 years ago

    hi @Hiaguedes, it looks great, as an improvement you can add correct margins. for example, in Ip address, location, etc they need more space in the bottom. good luck

    1
  • Abdulla Bashiroglu•520
    @bashirogluPosted about 4 years ago

    Hi @Mostafa-T, it looks great. I think you forget to add " sign to the background . Good luck

    0
  • Sam Buxcey•35
    @sjbcreativeSubmitted about 4 years ago

    Would be great to know peoples thoughts on the basic Javascript I have used to get the popup working, or if anyone has suggestion for how this whole part could be improved... Have I over-complicated this part of the task?

    Also general Markup thoughts and feedback appreciated!

    Thanks, S

    Article Card Preview | SASS, HTML, JQuery

    2
    Abdulla Bashiroglu•520
    @bashirogluPosted about 4 years ago

    Hi @sjbcreative, so your solution looks great. And using jquery for this task is okay. If you want to learn vanilla js, you can use dom manipulation. It is easier than jquery in this particular case. Good luck

    1
  • Abdulla Bashiroglu•520
    @bashirogluPosted about 4 years ago

    HI @shivamvijaywargi , It will be perfect with practice. As a feedback to your work, it already looks well done. as a improvement you can change bg image in mobile by using media queries. Good luck.

    0
  • Abdulla Bashiroglu•520
    @bashirogluPosted about 4 years ago

    Hi @zuolizhu, this looks amazing. Only thing I noticed, in the form section inputs somehow crapped from the top. especially with "f" it looks clear what I want to say.

    1
  • Abdulla Bashiroglu•520
    @bashirogluPosted about 4 years ago

    Hi @KimHungChan, everything looks good, It can be improved with some better naming for example buttons container can be changed because they are not probably buttons. Good luck.

    1
  • Abdulla Bashiroglu•520
    @bashirogluPosted about 4 years ago

    Hi @FelipeDecome, it looks great, however, i noticed the store card get so small before vertical align, you can add some min width or change vertical design earlier. Good luck.

    1