Fylo data storage component - React

Community feedback

• 

  Mark Mitchell•1,820

  @markup-mitchellPosted about 4 years ago

  Hi Kimhung. The responsiveness looks pretty good to me! I'd leave out whatever's happening at the 521px breakpoint; just leave it as the mobile design until it gets wide enough to accommodate the desktop design.

  If you're going to nest the storage bar's dot inside the inner bar, you could set inner-bar's display to flex and justify-content: flex-end - then you can adjust the width of the parent div and the dot will stay positioned. That lets you avoid adjusting magic numbers like margin-left: 97%. demo here.

  A square div can be made circular with border-radius: 50% - using a rem value could be a bit confusing there.

  Oh, and background-position: bottom right; will take the bg up to edge of the screen.

  But these are all just little details!

  2
• 

  Abdulla Bashiroglu•520

  @bashirogluPosted about 4 years ago

  Hi @KimHungChan, everything looks good, It can be improved with some better naming for example buttons container can be changed because they are not probably buttons. Good luck.

  1
• 

  Michael•110

  @KimHungChanPosted about 4 years ago

  Thanks a lot for the feedback! Lots of great points. I'll make these changes soon :) Let me know if you ever need a pair of eyes too.

  0