Article Card Preview | SASS, HTML, JQuery

Community feedback

• 

  Sankara Gomathy M•455

  @sankaragomathymPosted about 4 years ago

  Hey! Nice work. There are few suggestions that I would like to give.

  1. It is always a good practice to load your script file at the end of the body as the DOM would have fully loaded and available for access in JS file.
  2. The share button in not visible in mobile view.

  Hope this helps.. :)

  1

  ---

  

  Sam Buxcey•35

  @sjbcreativePosted about 4 years ago

  @sankaragomathym thanks very much for the feedback Sankara! Thanks for flagging the script order issue!

  I think the share button not viewable on mobile is something to do with my java script and a style only kicking in at a certain width. Will be sure take a 2nd look at this and fix.

  Thanks again! S

  0
• 

  Abdulla Bashiroglu•520

  @bashirogluPosted about 4 years ago

  Hi @sjbcreative, so your solution looks great. And using jquery for this task is okay. If you want to learn vanilla js, you can use dom manipulation. It is easier than jquery in this particular case. Good luck

  1

  ---

  

  Sam Buxcey•35

  @sjbcreativePosted about 4 years ago

  @bashiroglu thanks for the feedback Abdulla, I know an okay ammont of Java script, always find that Jquery really quickly gives me all the tools I need on a regular basis! Definately something I will think about more in the future though. Thanks again!

  1

  

  Abdulla Bashiroglu•520

  @bashirogluPosted about 4 years ago

  @sjbcreative This my subjective opinion but will be useful to you. Jquery prevents you from learning real JS and you eventually need Js for React, Vue, etc. I decided not to use Jquery at all when I was learning. And I happy about that decision. Because my Js skills helped to grasp React and Node easily. Good luck

  0