@brunopistarinoSubmitted over 2 years ago
Bartosz Dudziak
@bartoszdudziak-devAll comments
- @bartoszdudziak-devPosted 5 months ago
It looks pretty good on all screen sizes. Your code is simple and clean.
There could be small improvement to prevent or display error message when user put negative numbers in bill input.
Great job! 🫡
1 - @jenna1kSubmitted 6 months ago@bartoszdudziak-devPosted 5 months ago
Your solution looks really close to the designed one.
I use Google Chrome and there is this ugly scrollbar in trendings section. It would be also cool to get some feedback when there is no bookmarks.
Great Job!🫡
0 - P@aouintihouariSubmitted 6 months ago@bartoszdudziak-devPosted 5 months ago
Well done!
What is your opinion about this challenge? Did you struggle with it like I did? 😅
I can't see any problems with your solution. Maybe some styling details differences comparing to desinged one.
0 - P@aouintihouariSubmitted 6 months ago
REST Countries API with Vite, React TypeScript and Tailwind CSS
#react#react-router#tailwind-css#vite#typescript@bartoszdudziak-devPosted 6 months agoIt looks almost perfect, code is simple and clean and also includes semtanic HTML.
I really love your card skeleton implementation when data is loading, I didn't think of that in my solution.
There is one thing to improvement. When I filter by region it would be cool to somehow get back all the countries.
Marked as helpful0 - @AlisCodeSpaceSubmitted 6 months ago@bartoszdudziak-devPosted 6 months ago
I see some problems with your solution.
- You should create some breakpoints to stop container from growing on screens smaller than 1200px
- Form errors are still visible even if I provide new correct values and calculate mortgage
- Labels don not work properly - most of them points to Mortgage Term input
- Clear all button could also clear the results container
Good luck! 🫡
Marked as helpful0 - @AlisCodeSpaceSubmitted 6 months agoWhat are you most proud of, and what would you do differently next time?
Made the application fully responsive on all devices, it was challenging but I'm happy about the outcome. I would organize my component tailwind styling better next time to avoid confusion.
Used React Context API for the first time.
What challenges did you encounter, and how did you overcome them?The modal was the most challenging part, gave me a headache, but it worked out in the end.
@bartoszdudziak-devPosted 6 months agoThere are some styling differences but It looks really cool. Good job! I like your solution for hiding a scrollbar.
The modal also was the most demanding for me. I wonder if it is the best solution for modals because it is on the website all the time...
0 - @daniloparrajrSubmitted 6 months agoWhat are you most proud of, and what would you do differently next time?
This is a fun quick project to get started working with next.js
- @bartoszdudziak-devSubmitted about 1 year agoWhat are you most proud of, and what would you do differently next time?
My solution looks quite similar to designed one. I created simple button click effect using event delegation but its not perfect.
What challenges did you encounter, and how did you overcome them?The most demanding for me was image behavior. I'm still not sure about its position, size etc. in responsive way. I overcome it with some height changes in image wrapper combined with image properties.
What specific areas of your project would you like help with?Any opinions will be helpful 🫡
@bartoszdudziak-devPosted 11 months agoThank you for the comment. I thought the
deferattribute insidescripttag solves this problem, doesn't it?0 - P@AdamHaniffSubmitted over 1 year ago@bartoszdudziak-devPosted 11 months ago
- Your solution is great! There is very good structure contains modules.
- It inspired me to refactor my own solution!
0 - @DarekReposSubmitted about 1 year agoWhat are you most proud of, and what would you do differently next time?
I'm proud that my solution is responsive and scores well using Lighthouse. if I had to work on this project again, I'd like to try creating a static template for a generator like Hugo, Eleventy, or Astro. This would allow me to reuse some components or elements. I'm not sure if my SCSS files are well-organized.
What challenges did you encounter, and how did you overcome them?The main problem was figuring out how to start and plan the order in which I should create each element. The hardest part was choosing a solution to the problem. For each element, there are different techniques that can be used. I hope I selected the best one.
What specific areas of your project would you like help with?I'm still learning CSS/SCSS and HTML. I'm not sure if my favicons are great, or if my code is well-structured and readable. Are there any improvements I could make?
@bartoszdudziak-devPosted 11 months agoOverall it looks good! 🫡 I have found that the mobile navbar appears during changing the screen width. It's something wrong with position and transform.
Marked as helpful1 - @OsmarPESubmitted 11 months ago
- @Jithin-b-pSubmitted about 1 year ago@bartoszdudziak-devPosted 11 months ago
It looks almost perfect! 😎 The solution is responsive, includes semantic HTML and is accessible.
- on my screen the background image doesn't fill entire width
- think about adding some transition to the accordion (it can be tricky)
0 - @jjdavenportSubmitted 12 months agoWhat are you most proud of, and what would you do differently next time?
First solution using JS.
What challenges did you encounter, and how did you overcome them?Mostly working out the logic behind the JS.
What specific areas of your project would you like help with?Any feedback regarding the JS functions, is my solution too complex?
@bartoszdudziak-devPosted 11 months ago- It works well but in my opinion it is too much nested I would say.
- I recommend you read about event delegation. You can have just one event listener attached to buttons container and work with
targetproperty. It is better for performance. - This can be helpful:
if(!e.target.closest('.button') return;
Marked as helpful1 - @AcharaChisomSolomonSubmitted 11 months agoWhat are you most proud of, and what would you do differently next time?
Nothing in particular, I am proud of it all
What challenges did you encounter, and how did you overcome them?I need to study up on transitions and transforms to know how to apply them effectively.
What specific areas of your project would you like help with?Any feedback is welcome!!!
@bartoszdudziak-devPosted 11 months agoIt looks almost perfect in my opinion 🫡
There are only some details you could improve:
- submit button doesn't inherit font family
- perhaps you should limit width of the option text to make some place for correct and incorrect icons
- when I scroll down the page and hover the answer option it moves the whole page
I will ensure improve my solution with concepts of yours!
Marked as helpful0 - @mbd89Submitted 12 months agoWhat are you most proud of, and what would you do differently next time?
.
What challenges did you encounter, and how did you overcome them?The hardest thing i've seen by far.,
What specific areas of your project would you like help with?.
@bartoszdudziak-devPosted 12 months agoI have found some bugs in your solution:
- if I click copy button it adds unnecessary text each click
- validation message should disappear after generate password
- rendering strength level should change only after generate password
- I think is better approach to add and remove specify classes instead off changing style property
Except that there are some solutions that I could use in my own project 🫡
Marked as helpful1 - @JreyIVSubmitted 12 months agoWhat are you most proud of, and what would you do differently next time?
I was able to work through the javascript and use console.log for testing. I was also able to refactor some of my code and make helper functions to make my code a little bit cleaner. Next time I will try to make it even cleaner.
What challenges did you encounter, and how did you overcome them?The javascript was still difficult. I had to look some little things up because I would forget how to do some things. It was also hard to make my javascript not too messy. I was able to refactor some things but I know that it can still be a lot cleaner and more effective. That will come with practice.
The responsiveness also gave me trouble. I figured out through testing that its because I had all of inputs wrapped in a form tag but I was applying my CSS grid to the calculator container so it was ignoring it. I will learn from that and not make that same mistake next time because it took me a while to figure out.
What specific areas of your project would you like help with?Regarding my javascript, are there ways to make it more efficient and cleaner/more readable? I want to practice making the cleanest code that I can.
@bartoszdudziak-devPosted 12 months agoHello! I've noticed a few things that you could improve.
- It would be good to create a validation because in your solution user is able to enter negative numbers. You can add some error messages for the user.
- Using label tags with tip options doesn't look correct for me. I would use simply buttons for the tip options
- Consider using event delegation. It makes your code more efficient, because you can create only one event listener on your radio buttons container not for each input separately. This video may be helpful.
Can't help much with clean code cuz I am still learning that 😅 I hope it will be useful 😀 Good luck!
1 - @0147ntekimSubmitted over 1 year ago@bartoszdudziak-devPosted 12 months ago
- Your should need to contain JavaScript code which make your site interactive. User should be able to swap between time frames.
- It is good start to create this challenge but you need to work on the right style.
0 - @KutayIncSubmitted about 1 year ago@bartoszdudziak-devPosted about 1 year ago
Hello!
- I would recommend you to limit width of your container in mobile view especially. It doesn't have to grow to the breakpoint all the time. You can combine
widthandmax-widthto achieve that - In my opinion breakpoint could come earlier. 1000px maybe🤔
- You should use
constinstead ofvarin your JavaScript file
Apart from these details, you solution looks quite cool. 🫡
Marked as helpful0 - I would recommend you to limit width of your container in mobile view especially. It doesn't have to grow to the breakpoint all the time. You can combine
