@jenna1kSubmitted about 1 month ago
P
Bartosz Dudziak
@bartoszdudziak-devAll comments
- @bartoszdudziak-devPosted about 1 hour ago
Your solution looks really close to the designed one.
I use Google Chrome and there is this ugly scrollbar in trendings section. It would be also cool to get some feedback when there is no bookmarks.
Great Job!🫡
0 - @aouintihouariSubmitted 22 days ago@bartoszdudziak-devPosted 14 days ago
Well done!
What is your opinion about this challenge? Did you struggle with it like I did? 😅
I can't see any problems with your solution. Maybe some styling details differences comparing to desinged one.
0 - @aouintihouariSubmitted 26 days ago@bartoszdudziak-devPosted 24 days ago
It looks almost perfect, code is simple and clean and also includes semtanic HTML.
I really love your card skeleton implementation when data is loading, I didn't think of that in my solution.
There is one thing to improvement. When I filter by region it would be cool to somehow get back all the countries.
Marked as helpful0 - @AlisCodeSpaceSubmitted 27 days ago@bartoszdudziak-devPosted 26 days ago
I see some problems with your solution.
- You should create some breakpoints to stop container from growing on screens smaller than 1200px
- Form errors are still visible even if I provide new correct values and calculate mortgage
- Labels don not work properly - most of them points to Mortgage Term input
- Clear all button could also clear the results container
Good luck! 🫡
Marked as helpful0 - @AlisCodeSpaceSubmitted 28 days agoWhat are you most proud of, and what would you do differently next time?
Made the application fully responsive on all devices, it was challenging but I'm happy about the outcome. I would organize my component tailwind styling better next time to avoid confusion.
Used React Context API for the first time.
What challenges did you encounter, and how did you overcome them?The modal was the most challenging part, gave me a headache, but it worked out in the end.
@bartoszdudziak-devPosted 28 days agoThere are some styling differences but It looks really cool. Good job! I like your solution for hiding a scrollbar.
The modal also was the most demanding for me. I wonder if it is the best solution for modals because it is on the website all the time...
0 - @daniloparrajrSubmitted about 1 month agoWhat are you most proud of, and what would you do differently next time?
This is a fun quick project to get started working with next.js
- @bartoszdudziak-devSubmitted 7 months agoWhat are you most proud of, and what would you do differently next time?
My solution looks quite similar to designed one. I created simple button click effect using event delegation but its not perfect.
What challenges did you encounter, and how did you overcome them?The most demanding for me was image behavior. I'm still not sure about its position, size etc. in responsive way. I overcome it with some height changes in image wrapper combined with image properties.
What specific areas of your project would you like help with?Any opinions will be helpful 🫡
@bartoszdudziak-devPosted 6 months agoThank you for the comment. I thought the
deferattribute insidescripttag solves this problem, doesn't it?0 - @AdamHaniffSubmitted about 1 year ago
Finally finished building this E-Commerce Product Page! It took me about five weeks to complete and I learned so many new things along the way. I wanted to tackle this challenge because it looked more difficult than the challenges I have already completed. I am planning on using this challenge in my portfolio. Let me know what you guys think!
@bartoszdudziak-devPosted 6 months ago- Your solution is great! There is very good structure contains modules.
- It inspired me to refactor my own solution!
0 - @DarekReposSubmitted 8 months agoWhat are you most proud of, and what would you do differently next time?
I'm proud that my solution is responsive and scores well using Lighthouse. if I had to work on this project again, I'd like to try creating a static template for a generator like Hugo, Eleventy, or Astro. This would allow me to reuse some components or elements. I'm not sure if my SCSS files are well-organized.
What challenges did you encounter, and how did you overcome them?The main problem was figuring out how to start and plan the order in which I should create each element. The hardest part was choosing a solution to the problem. For each element, there are different techniques that can be used. I hope I selected the best one.
What specific areas of your project would you like help with?I'm still learning CSS/SCSS and HTML. I'm not sure if my favicons are great, or if my code is well-structured and readable. Are there any improvements I could make?
@bartoszdudziak-devPosted 6 months agoOverall it looks good! 🫡 I have found that the mobile navbar appears during changing the screen width. It's something wrong with position and transform.
Marked as helpful1 - @OsmarPESubmitted 6 months ago
- @Jithin-b-pSubmitted 10 months ago@bartoszdudziak-devPosted 6 months ago
It looks almost perfect! 😎 The solution is responsive, includes semantic HTML and is accessible.
- on my screen the background image doesn't fill entire width
- think about adding some transition to the accordion (it can be tricky)
0 - @jjdavenportSubmitted 7 months agoWhat are you most proud of, and what would you do differently next time?
First solution using JS.
What challenges did you encounter, and how did you overcome them?Mostly working out the logic behind the JS.
What specific areas of your project would you like help with?Any feedback regarding the JS functions, is my solution too complex?
@bartoszdudziak-devPosted 6 months ago- It works well but in my opinion it is too much nested I would say.
- I recommend you read about event delegation. You can have just one event listener attached to buttons container and work with
targetproperty. It is better for performance. - This can be helpful:
if(!e.target.closest('.button') return;
Marked as helpful1
