Skip to content
OverviewSolutions
26
Comments
36
P

Yulia

@YuliaLantzberg720 points

I am a self-taught software developer with 4+ years of experience working with full-stack. What I like the most about this profession is its never-ending learning, mix of creativity and logic, problem-solving and simply fun.

I’m currently learning...

Linux, Docker, Scss

Latest solutions

View more solutions

Latest comments

  • P
    Yulia•720
    @YuliaLantzbergPosted 3 months ago

    Hi. It's working great. But I can't review the code as it's not formatted. Yes, I think it's a matter of personal (or company's preferences) whether to reset the form or not after sending it. When you reset it, it makes it clearer to the user that something happened when he pushed the button. On the other hand, if the user forgot to say something, or wants to give additional info, he will have to fill the form again. So both approaches have the right to exist. Another thing I've noticed, everything is working perfectly for keyboard navigation, except the concern checkbox. I couldn't find the way to check it without using mouse

    Marked as helpful
    0
  • P
    Yulia•720
    @YuliaLantzbergPosted 3 months ago

    Hi. It's looking great and indeed perfect pixel. Only thing is, I felt it's extremely hard to read code with naming that is not related to the actual page. I mean, shopping cart, product_list, product_page. It really makes it hard to understand wich element on the page is related to the actual code and so it would be hard to maintain or for example to get new members of the team introduced to the code in the real world. In this particular case, if talking react, I'd rather break it into many small components related to the UI. Like ability_score, ability_name, total_score, button. And then to compose them into cards and lists and then to compose them into a page. I mean, like a general idea of course. I hope it makes sense. But from a user perspective, the result is looking really great.

    0
  • Andrey•2,570
    @dar-juSubmitted 3 months ago
    What challenges did you encounter, and how did you overcome them?

    This task is clearly not a newbie. For it to work and look nice, you need advanced knowledge of CSS.

    Had to work with indents in CSS so that the accordion could expand the number of blocks without rewriting styles.

    What specific areas of your project would you like help with?
    1. Due to the fact that a limited height of the text block is used, there are restrictions on the text size. If there is more text, then you need to manually change the height. If make an automatic height, then the opening and closing of the block will not be smooth.

    Also, because of the height of the block, there is a twitch when collapsing.

    1. It was not possible for me to make it accessible from the keyboard without JS (

    FAQ accordion

    #bem
    1
    P
    Yulia•720
    @YuliaLantzbergPosted 3 months ago

    Hi. Wow. It's looking like a perfect pixel. Great work. But unfortunately, it is not responsive. It's better to use rems instead of px. And if it's not enough than also media queries. About the second question. You can use tabindex="0" in your HTML code. It will not be the perfect handle of the keyboard. But still, it will enable you to navigate with a keyboard.

    0
  • P
    Yulia•720
    @YuliaLantzbergPosted 3 months ago

    Hi Erick. Your page is working perfectly and everything looking great. Just maybe a bit higher, so scroll is not comfortable for this page I think. It's hard to read code as it's a mix of English and another language. The thing that I could notice is, it seems you have a repeating code in mundacaImg and ativo functions. So, you can distinguish it into a separate function. Also, it seems like that will be a better use of switch rather than if else for better readability (but it's rather personal preference). And even better to use the loop, so it can to shorten the code pretty much. Hope it makes sense.

    0
  • Weverson Godinho•490
    @GodinhoweversonSubmitted 3 months ago
    What challenges did you encounter, and how did you overcome them?

    I encountered a challenge with CSS Grid. I'm not used to Grid, but I read some articles on https://css-tricks.com/ that helped me overcome this challenge.

    news-homepage

    2
    P
    Yulia•720
    @YuliaLantzbergPosted 3 months ago

    Hi. Very good solution, way better than mine. I can hardly give helpful feedback here. The only thing is, maybe to wrap the list items in nav into a tag as if it would be a real site, then they'd be hyperlinks. There is also no hover effect on those links. Other than that, code looks so clean and works perfectly.

    Marked as helpful
    0
  • P
    Yulia•720
    @YuliaLantzbergPosted 3 months ago

    Hi. Good job. But there are a few bugs. First of all the form allows to submit even tho not all required fields are filled. Only name and email are enough to send the form. Also, when navigating with keyboard the radio buttons, checkbox and button are skipped or not skipped but there is no any visual sign that they are focused. Also there is no need to get. But CSS is perfect and there is semantic HTML 👍 Hope it's helpful

    Marked as helpful
    0
View more comments