
Submitted 4 months ago
E-Commerce Product Page using Less, Bem and vanilla Javascript
#less#bem
P
@YuliaLantzberg
Design comparison
SolutionDesign
Community feedback
- P@juliengDevPosted 2 months ago
Code Review Report
Issues Identified
1. Cart Functionality
- The cart is not working correctly when I arrived on the desktop version, and its functionality needs debugging.
2. Layout Behavior
- There is a strange layout behavior related to viewport height, which can be observed when using the browser's responsive DevTools. This suggests a potential issue with the CSS or HTML structure.
3. Mobile Version Issues
- On mobile devices, the cart appears to function, but its layout on the page is incorrect.
- There are difficulties closing the cart once it has been opened.
4. Accessibility Concerns
- The site was not developed following accessibility standards, which could impact usability for a wider audience.
Recommendations
- Fix the cart functionality to ensure items can be added, removed, and viewed correctly.
- Investigate and resolve the viewport height issue to improve layout consistency.
- Adjust the cart layout on mobile for better positioning and usability.
- Ensure proper event handling to allow users to close the cart easily.
- Improve accessibility by following best practices, such as semantic HTML, keyboard navigation support, and ARIA attributes where necessary.
Feedback
I hope this review will help you to improve your project and continue growing as a developer. Happy coding and keep up the great work!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord