E-commerce product page challenge hub sass

Community feedback

• 

  P

  Yulia•720

  @YuliaLantzberg

  Posted 4 months ago

  Hi Erick. Your page is working perfectly and everything looking great. Just maybe a bit higher, so scroll is not comfortable for this page I think. It's hard to read code as it's a mix of English and another language. The thing that I could notice is, it seems you have a repeating code in mundacaImg and ativo functions. So, you can distinguish it into a separate function. Also, it seems like that will be a better use of switch rather than if else for better readability (but it's rather personal preference). And even better to use the loop, so it can to shorten the code pretty much. Hope it makes sense.

  00