Skip to content
OverviewSolutions
4
Comments
32

Saleiux

@Saleiux230 points

I'm always looking for new challenges, eager to leave an impact and curious about the world! I’m working hard to achieve ambitious results, with like-minded peo

Latest solutions

Latest comments

  • Saleiux•230
    @SaleiuxPosted about 1 year ago

    Good job! some suggestions:

    • Your card look so much smaller than the one in the example, you can align it in the center of the page with flexbox, for example, and after working with size and width for making it more similar as possible to the example
    • Add a readme.md file in your repo with an overview of your project, it will help visitors to understand what you did and with which stack
    • For this project it was not necessary but try to use semantic html in your projects, like main, section, footer...
    • I suggest you to call your .css file styles.css it will be more clear in bigger projects
    • In your folder "qr-code-component-main" you have many file that you can delete. I hope those tips can help you to improve, good luck!
    Marked as helpful
    0
  • Saleiux•230
    @SaleiuxPosted about 1 year ago

    Hi! good job! something that I notice in your project:

    • The alignment of your card is on the right while in the example is in the middle! There are many ways to align items, you can try, for example, with flexbox
    • Try to be more comprehensive and detailed in your readme.md file
    • You need to create a conteiner for all your items, like in the example
    • Try to work with the width of your image, it looks so much bigger than the one in the example I hope this will be helpful, good luck!
    1
  • Saleiux•230
    @SaleiuxPosted about 1 year ago

    Hi good job! What I notice in your project:

    • I think you need to work a bit with the size of your card, it looks so much bigger than the one in the example
    • Add a Readme.md file with an overview about your project I hope this will help you!
    0
  • Saleiux•230
    @SaleiuxPosted about 1 year ago

    Hi! good job! Some suggestions_

    • I see that your card is not align perfectly in the center, there are many ways to do that but you can try with flexbox for example!
    • I suggest you to use an external file for css
    • If you edit your readme.md file will be easier to have an overview fo your project! I hope this will be helpful, good luck!
    Marked as helpful
    0
  • Saleiux•230
    @SaleiuxPosted about 1 year ago

    Hi! this wasn't an easy challenge so good job! Some suggestion:

    • There are some items overlap with others, like the div with the class="testimonial" in mobile but also desktop design. I see that you never use position:absolute and relative in the css fyle, try them, they will hwlp you with this
    • You can use the file style-guide for using in the right way the background colours or images
    • You need to take a look to margin between section, I see some white space where there shouldn’t be
    • I suggest you to use some semantic html and comment so it will be more easy to read your code I hope that those suggestions can help you! Good luck and keep it!
    Marked as helpful
    0
  • Saleiux•230
    @SaleiuxPosted about 1 year ago

    Happy for your first project! You did a great job! the only thing that I can suggest you is to add a readme.md file on your repo so it will be easier to have an overview of your project!

    1
View more comments