QR code component with Bootstrap and Sass

Community feedback

• 

  Jon Henrik Åvitsland•190

  @jonhenrikaavitslandPosted 11 months ago

  Also if you want some resources on flex and grid for layout these did me well:

  https://css-tricks.com/snippets/css/a-guide-to-flexbox/ https://css-tricks.com/snippets/css/complete-guide-grid/#aa-introduction Also i think you should read up on box-sizing border-box: https://developer.mozilla.org/en-US/docs/Web/CSS/box-sizing

  Good luck

  Marked as helpful

  0

  ---

  

  Saleiux•230

  @SaleiuxPosted 11 months ago

  Thank you so much Jon! I will use your tips and look at the resources! @jonhenrikaavitsland

  0
• 

  Jon Henrik Åvitsland•190

  @jonhenrikaavitslandPosted 11 months ago

  Hi Saleiux, thanks for the follow. I follow you back ofc :)

  I know that you are learning to code, so am I, currently by school tho. But looking at your code, I want to mention some ideas that come to my mind and I hope it helps you improve on this design and furthermore when you work on new designs.

  I suppose that you are a free user, if you pay for the membership you do get design files that you can utilize to improve beyond just the visual picture, but you don't have to.

  I think that you forgot to declare the font family in your CSS file. You imported some font, but I can not see that it has been declared yet.

  Also, I see that you are using padding to position your elements within the card, perhaps could flex have been used to some extent :)

  You are using the rem unit size for width, I would rather use the rem unit size on font-sizes and a different unit on the width, and I think that in your case px is fine for width :)

  Marked as helpful

  0