Design comparison
SolutionDesign
Solution retrospective
I wasn’t sure how to center my elements in the middle of the page, did I do it the right way?
My HTML can be improved?
Did I use css best practices?
Community feedback
- @MelvinAguilarPosted 11 months ago
Good job on completing the challenge !
I have some suggestions about your code that might interest you.
- Use semantic elements such as
<main>
and<footer>
to improve accessibility and organization of your page.
- The issue I see is that the height of the
.page
element is too small; you should usemin-height: 100vh
to cover 100% of the device height and remove theheight: 800px;
. Additionally, consider addingjustify-content: center
in the.page
element to vertically center the element instead of usingmargin-top: 180px
.
Happy coding!
Marked as helpful0 - Use semantic elements such as
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord