QR Code with basic html and css

Community feedback

• 

  Hale•330

  @halelitePosted 9 months ago

  hi @JesuCeron!

  Good job! Your solution looks great!

  I just noticed a small thing about your CSS. In the design, the component is centered both horizontally and vertically. I suggest you center your component vertically as well, so your project looks way much better. There are a lot of ways to center it. Some of them are:

  • using flexbox
  • using margin or padding
  • using absolute position property

  position: absolute
  top: 50%;
  transform: translateY(-50%);
  

  Other that that great job! 👍

  I hope it helps!

  Marked as helpful

  0

  ---

  

  Andres Ceron•50

  @JesuCeronPosted 9 months ago

  @halelite Thanks for your advice.

  0
• 

  Saleiux•230

  @SaleiuxPosted 9 months ago

  Good job! some suggestions:

  • Your card look so much smaller than the one in the example, you can align it in the center of the page with flexbox, for example, and after working with size and width for making it more similar as possible to the example
  • Add a readme.md file in your repo with an overview of your project, it will help visitors to understand what you did and with which stack
  • For this project it was not necessary but try to use semantic html in your projects, like main, section, footer...
  • I suggest you to call your .css file styles.css it will be more clear in bigger projects
  • In your folder "qr-code-component-main" you have many file that you can delete. I hope those tips can help you to improve, good luck!

  Marked as helpful

  0

  ---

  

  Andres Ceron•50

  @JesuCeronPosted 9 months ago

  @Saleiux Thanks for your advice.

  0