Skip to content
OverviewSolutions
14
Comments
5
Ric
@Ripra87

All comments

  • Ric•210
    @Ripra87

    It looks really good ) nothing to say, happy coding! ))

  • Ric•210
    @Ripra87

    Really nice work, i also just finished this challenge! )) By the way, to make a site responsive you should add a "second" part of code in your CSS. Using the command:

    @media screen and (min-width: 1100px) {

    }

    you can use min-width o max-width, depending from which design you make first (desktop or mobile) and indicate the size of the screen (here 1100px but it can be different) where your page move to the other style.

    Inside the pharentesis you should srite the css code with the new rules )) You can check my css code to have an idea.

    I hope my comment will help you, by the way really nice projects! Good work and Happy Coding!!

    Marked as helpful
  • Ric•210
    @Ripra87

    Hi Morden, I checked your code, i'm not so expert but i noticed that the heigth of your image container is bigger than your image, so the bottom border of your image is cutted, your image is 300 x 300 px, and the container is 300 x 304 px, if you change your container to the same size of the image it should work. You can easily see it with pesticide, if you don't have it i really suggest you to download, is a browser extension :)

  • Ric•210
    @Ripra87

    Thank both guys it works )) i used vw and now is centered, but i had to set the body height at 50vw, with 100 is double size and i have to use the scroll bar :P For Aliyu-Saidu i used the h3 only because looking at the font size in the pictures it looked so small, but i could anyway use the h1 and resize it, right ) About the percentage, i read somewhere that is always better to use percentage or em (or rem for children) because it makes the page more responsive, with the px it doesn't happen, isn't it right?

  • Ric•210
    @Ripra87

    @AdrianoEscarabote It really helps Adriano thank you so much! Till now i only studied the main display, block, inline and inline-block. I now read something on w3schools about the flex display and it looks like to be perfect! I'll try to recode the challenge using your tips, thank you again! About the alt in the image i forgot it :P And for the main tag, i knew it just i didn't put so much attention on it concentrating to the css code, but you're right i have to take the habit to code the HTML in the correct way in any situation! aria-hidden="true" --> this atribute is new for me, i still never see it, i'll check around for it to understand in better )