Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code component

@Mariam-Saeed

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Hassia Issah 50,670

@Hassiai

Posted

wrap <div class="attribution"> in the footer tag to fix the accessibility issue.

To center the section on the page using flexbox, replace the height in the main with min-height: 100vh.

For a responsive content, replace the width in the section and img with max-width.

Give h1 and p the same font-size of 15px which is 0.9375rem, text-align: center, the same margin-left, margin-right and margin-top values. Give p a margin bottom value.

Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

Hope am helpful.

Well done for completing this challenge. HAPPY CODING

Marked as helpful

1

@Mariam-Saeed

Posted

@Hassiai Thanks a lot. I will follow this guide !😊

0

@Akhil-Nagpal

Posted

Hello Mariam! Congratulations on completing your first project! 🎊

To fix the accessibility error, you need to change this thing in your code:

  • Just nest the attribution group element inside the <main> tag. This will fix the landmark error.

Other Suggestions:

  • In CSS always try to use relative units like em or rem instead of absolute units like px. Using these relative units will improve the responsiveness. Read this for a better understanding 👉 Should we use Rem, Em, or Pixel?
  • There's a slight drop shadow under the card. Try to add a box shadow to the card. This will bring your solution near to perfect.

Otherwise! You did an amazing job! Well Done! 👌

I hope this will help you to improve! 😄

Happy Coding!

Marked as helpful

1

@Mariam-Saeed

Posted

@Akhil-Nagpal Thanks a lot! I will improve those things 😊

0
Temsaah 450

@Temsaah

Posted

To fix the accessibility issue you should replace the "<div class="attribution">" with footer tag someone told me about that before i am just a beginner. and the design looks almost identical well done !

Marked as helpful

1

@Mariam-Saeed

Posted

@Temsaah I will. Thanks a lot !

0
Ric 210

@Ripra87

Posted

It looks really good ) nothing to say, happy coding! ))

1

@Mariam-Saeed

Posted

@Ripra87 Thanks a lot!😊

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord