Skip to content
OverviewSolutions
4
Comments
9
Renato Granados
@Renato6GS

All comments

  • 👾 Ekaterine Mitagvaria 👾•7,600
    @catherineisonlineSubmitted over 2 years ago

    Hello, Frontend Mentor community! This is my solution to the Calculator App.

    I appreciate all the feedback you left that helped me to improve this project. I fixed the issues I had previously and added new features per your recommendation.

    I have done this project a while ago however if you are here and have any feedback, tips, or ideas to share, I will be more than glad to hear them out!

    Thanks

    Calculator App

    8
    Renato Granados•180
    @Renato6GSPosted over 2 years ago

    Congratulations Cathering, your deisgn is excellent.

    When I use the calculator via my keyboard, the app freezes. Maybe an infinite loop? I recommend you use try/catch in the math operations, with that way, maybe the main thread won´t freeze

    Marked as helpful
    1
  • Renato Granados•180
    @Renato6GSPosted almost 3 years ago

    Very good job on the design, although I don't know why the seconds and hours are reduced at the same time.

    And, maybe this video can help you with that flip animation: https://www.youtube.com/watch?v=t56nSwjozf0

    Marked as helpful
    0
  • Guillermo•170
    @Guille2000Submitted almost 3 years ago

    Finally, here is my solution. I had fun doing this one! If you have any advice, or there's something i should improve, please tell me! I'm excited to see your comments! :)

    Responsive Fylo using BEM and SCSS

    1
    Renato Granados•180
    @Renato6GSPosted almost 3 years ago

    very good work. Although I think the card quotes appear outside, right? It may be that you are adding these quotes outside the card container

    Marked as helpful
    0
  • Renato Granados•180
    @Renato6GSPosted almost 3 years ago

    Great job, I like it 👍

    1
  • Renato Granados•180
    @Renato6GSPosted almost 3 years ago

    HI!

    Good work in this challenge 😀

    Maybe, you might to use the 100% of the width, because there are two thick white borders from side to side.

    Other thing, the Image "sugar cubes" does not load.

    Marked as helpful
    0
  • Rafal•1,395
    @grizhlieCodesSubmitted almost 3 years ago

    Hey all,

    (Question on the bottom, summary on the top).

    Just one I did for fun. I realised I could practice building keyboard-accessible navigation with some thought given to tabindex and when to add/remove it from the collapsible links. Then I realised how badly I wrote my JS and refactored it to be more readable.

    I gave special attention to the transitions/animations for the header. You will see the collapsible menu-categories transition themselves from the direction/location of the buttons that activate them. I also added smooth transitions for the actual link-containers as well, the max-height, gap, padding and margin properties together is what makes the smoothness possible.

    Also learned about what exactly scrollHeight is and that it does not seem to include some aspects of the content, I believe it was omitting/excluding line-height of my <a>'s for example. It also ignores things like the gap property of any parent flex container. So I just wrote my own customScrollHeight variable. All in all I didn't expect to learn so much, as minor as it may seem at first. AWESOME project.

    I paid attention to making sure the grids I used were smooth. I did NOT pay attention to the background image for the hero, just sort of threw it in there with rough calculations, I'm sorry :(.

    Question: Does anyone have any good thinking-framework for working with CSS grid? Some sort of a mental model with which to follow and break grid-down? My current style is based on analysing the design and then just fitting the grid in, mobile first with an OK understanding of the various grid-units we can use for rows/columns. But beyond that it's laissez faire.

    Cheeeeeeers 😁

    Blogr Landing Page - Accessible Nav & Fluid grid

    3
    Renato Granados•180
    @Renato6GSPosted almost 3 years ago

    Hello

    The images of the articles are not the same as the design. I think it is a Chrome and Edge problem, because in Firefox it does work perfectly.

    I recommend that you try your practices in different browsers.

    Marked as helpful
    1
  • Paul•170
    @paultadesseSubmitted almost 3 years ago

    Any feedback on my code would be highly appreciated.

    Space Tourism

    1
    Renato Granados•180
    @Renato6GSPosted almost 3 years ago

    Hi! Good work :D

    I dont know why, but when I navigate in other sections, the image does not load and background is in white

    0
  • Renato Granados•180
    @Renato6GSPosted almost 3 years ago

    Hi!

    Very well done 😀

    Maybe, you may fix a responsive problem, but the "card" from an "IPad Pro" is too small.

    0
  • Anthony Rosman•510
    @D3press3ddSubmitted almost 3 years ago

    This is my first challenge, the most difficult part for me was the hover in the image, i think i could improve a little bit more, but im still learning, im so proud that i could did it, happy codding guys♥,

    Nft Card Component Solution

    5
    Renato Granados•180
    @Renato6GSPosted almost 3 years ago

    Hi from Facebook!

    Very good job Rosman, I like the effect you put on the image.

    I get a small responsive error on screens larger than 20 inches, the card is not centered. And on screens larger than 1024px in height, the card looks too small.

    I can suggest you use "media querys" to adjust the card size and font size according to the user's screen.

    1