Skip to content
OverviewSolutions
4
Comments
28

favour Aniogor

@PhantomOzLagos, Nigeria275 points

I am a Full-Stack Developer and App Developer. I love gaming and watching movies.

Latest solutions

Latest comments

  • favour Aniogor•275
    @PhantomOzPosted over 1 year ago

    Hello Chinwe, Great Job. Are you participating in the ongoing Hacktoberfest?

    0
  • favour Aniogor•275
    @PhantomOzPosted almost 2 years ago

    Good Job VictorWest ✌️, Here are Helpful tips I think can help improve your challenge:

    1. Your code should be semantic and you should try giving your classes a constant naming convention.
    2. Your code is also not really accessible.
    3. Your layout is responsive, Great Job ✌️.
    4. Your is not well-structured, readable, and reusable. There are minor issues with the color you used for the button and your border-radius. You should try wrapping the whole code inside your body element with a <div class="container"> or a main element for your boxshadow
    Marked as helpful
    1
  • favour Aniogor•275
    @PhantomOzPosted almost 3 years ago

    Nice job Rob, here is my feedback:

    • Good job trying to write semantically but, there are some areas where you could have placed semantic elements.
    • You should try fixing your 'accessibility' issues by formatting your code well.
    • You should try fixing your 'HTML' issues by:
      1. This code in the header <a href="##"> <img class="logo" src="" alt="Sneakers logo"> </a> you should remove the second # in the href attribute.
      2. This code also ```<button type="button" class="btn add-to-cart-btn"> <p>Add to cart</p> </button>``` you can't have a block element `p` in an inline element `button` you should fix it.
    • The layout looks good on both Desktop and mobile screens but, I think you can still work on the typography especially the font-weight and font-size of some of the element so it resembles the design. The logo also looks chopped off underneath usually on Desktop screens.
    • You should also structure your code well.

    Good Job by the way 👍, I hope you found this feedback helpful.

    1
  • favour Aniogor•275
    @PhantomOzPosted almost 3 years ago

    Hello Hassan,

    • You should try fixing your accessibility issues by formatting your code well.
    • You should also try writing semantic HTML
    • Your site only looks nice on screens that are 1440px and larger.
    • You need to work on your code structure and readability.
    • Try improving your skill with CSS grids.

    Nice job by the way, I hope this feedback was helpful 👍

    Marked as helpful
    0
  • favour Aniogor•275
    @PhantomOzPosted almost 3 years ago

    Great Job Gabriel, Here is my feedback:

    • I love the fact that you used ReactJs and still tried writing semantically.
    • Your site is very accessible.
    • It looks good on both Desktop and Mobile devices.
    • Your codes are well-structured and very readable.

    Great Job 👍

    1
  • favour Aniogor•275
    @PhantomOzPosted almost 3 years ago

    Nice work Saajeves, Here are my feedbacks:

    • You should fix your accessibility by formatting your code well.
    • You try writing semantically.
    • You did a good job with accessibility except for the part where you gave your tabindex attribute a value of 1, if you use 0 your site still works as expected. We try avoiding values greater than 0 cause it is difficult for people who rely on assistive technology to navigate and operate page content.
    • Your page looks good both on desktop and mobile.
    • Your code is well-structured and very reusable.
    • Suggestion: you should try adding the CSS transition property on img element each time the image changes for ease in.

    Excellent Job by the way 👍, I hope this feedback was helpful.

    0
View more comments